Skip to content

Commit c51be7a

Browse files
akurtakovakurtakov
committed
Fix invisible/barely visible Go button in help webapp
This is coming from usage of deprecated css colors (https://developer.mozilla.org/en-US/docs/Web/CSS/system-color#deprecated_system_color_keywords ) which Webkit seems to no longer support at all and Firefox has some very basic and no longer good support. Replaced the deprecated colors with their "analogs" as per that page. Fixes eclipse-platform#1823
1 parent fc7bdeb commit c51be7a

17 files changed

Lines changed: 67 additions & 77 deletions

‎ua/org.eclipse.help.webapp/advanced/advanced.jsp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ BODY {
4141
font: <%=prefs.getViewFont()%>;
4242
font-size: .875rem;
4343
background:<%=prefs.getToolbarBackground()%>;
44-
border:1px solid ThreeDShadow;
44+
border:1px solid CanvasText;
4545
padding:0px;
4646
margin:0px;
4747
}
@@ -72,14 +72,14 @@ FORM {
7272
}
7373
7474
#searchWord {
75-
border:1px solid ThreeDShadow;
75+
border:1px solid CanvasText;
7676
width:100%;
7777
font:icon;
7878
font-size:.875rem;
7979
}
8080
8181
#booksContainer {
82-
border:1px solid ThreeDShadow;
82+
border:1px solid CanvasText;
8383
margin:0px 10px;
8484
overflow:auto;
8585
}
@@ -99,7 +99,7 @@ FORM {
9999
if (data.isMozilla()) {
100100
%>
101101
input[type="checkbox"] {
102-
border:2px solid ThreeDShadow;
102+
border:2px solid CanvasText;
103103
margin:0xp;
104104
padding:0px;
105105
height:12px;
@@ -225,7 +225,7 @@ for (int i=0; i<tocData.getTocCount(); i++)
225225
<table cellspacing=10 cellpading=0 border=0 align=<%=isRTL?"left":"right"%> style="background:transparent;">
226226
<tr>
227227
<td>
228-
<input id="searchButton" class='button' type="submit" role="button" onclick="doAdvancedSearch()" value="<%=ServletResources.getString("SearchLabel", request)%>" id="go" alt="<%=ServletResources.getString("SearchLabel", request)%>" title="<%=ServletResources.getString("SearchLabel", request)%>">
228+
<input class='button' type="submit" role="button" onclick="doAdvancedSearch()" value="<%=ServletResources.getString("GO", request)%>" id="go" alt="<%=ServletResources.getString("SearchLabel", request)%>" title="<%=ServletResources.getString("GO", request)%>">
229229
</td>
230230
<td>
231231
<input class='button' type="button" onclick="window.close()" type="button" value="<%=ServletResources.getString("Cancel", request)%>" id="cancel" alt="<%=ServletResources.getString("Cancel", request)%>" title="<%=ServletResources.getString("Cancel", request)%>">

‎ua/org.eclipse.help.webapp/advanced/content.jsp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,16 @@
3030
if (data.isMozilla()) {
3131
%>
3232
HTML {
33-
border-<%=isRTL?"left":"right"%>:1px solid ThreeDShadow;
33+
border-<%=isRTL?"left":"right"%>:1px solid CanvasText;
3434
}
3535
<%
3636
} else {
3737
%>
3838
FRAMESET {
39-
border-top:1px solid ThreeDShadow;
40-
border-left:1px solid ThreeDShadow;
41-
border-right:1px solid ThreeDShadow;
42-
border-bottom:1px solid ThreeDShadow;
39+
border-top:1px solid CanvasText;
40+
border-left:1px solid CanvasText;
41+
border-right:1px solid CanvasText;
42+
border-bottom:1px solid CanvasText;
4343
}
4444
<%
4545
}

‎ua/org.eclipse.help.webapp/advanced/deferredView.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
body {
1616
font: <%=prefs.getViewFont()%>;
1717
font-size: .875rem;
18-
color: WindowText;
18+
color: CanvasText;
1919
margin-top: 8px;
2020
margin-left: 10px;
2121
margin-right: 10px;

‎ua/org.eclipse.help.webapp/advanced/indexView.css‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ INPUT {
4949
font-size:.875rem;
5050
margin:0;
5151
padding:0;
52-
border:1px solid ThreeDShadow;
52+
border:1px solid CanvasText;
5353
}
5454

5555
INPUT {
@@ -76,8 +76,8 @@ INPUT {
7676
}
7777

7878
#button {
79-
background:ThreeDShadow;
80-
color:Window;
79+
background:CanvasText;
80+
color:Canvas;
8181
font-size: 1.0em;
8282
font-weight:bold;
8383
margin-left:1px;
@@ -162,7 +162,7 @@ IMG.expander, IMG.h {
162162
A {
163163
text-decoration:none;
164164
padding-<%=isRTL?"left":"right"%>:2px;
165-
color:WindowText;
165+
color:CanvasText;
166166
/* this works in ie5.5, but not in ie5.0 */
167167
white-space: nowrap;
168168
}

‎ua/org.eclipse.help.webapp/advanced/list.css‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*******************************************************************************/
1414

1515
BODY {
16-
color:WindowText;
16+
color:CanvasText;
1717
font: <%=prefs.getViewFont()%>;
1818
font-size: .875rem;
1919
margin-top:5px;
@@ -25,7 +25,7 @@ BODY {
2525

2626
A {
2727
text-decoration:none;
28-
color:WindowText;
28+
color:CanvasText;
2929
padding:0px;
3030
white-space: nowrap;
3131
}
@@ -85,7 +85,7 @@ TABLE {
8585

8686
.unselectedMenuItem {
8787
background:<%=prefs.getToolbarBackground()%>;
88-
color:WindowText;
88+
color:CanvasText;
8989
padding-left:10px;
9090
padding-right:10px;
9191
}

‎ua/org.eclipse.help.webapp/advanced/nav.jsp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
if (!data.isMozilla()) {
3030
%>
3131
FRAMESET {
32-
border-top:1px solid ThreeDShadow;
33-
border-left:1px solid ThreeDShadow;
34-
border-right:1px solid ThreeDShadow;
32+
border-top:1px solid CanvasText;
33+
border-left:1px solid CanvasText;
34+
border-right:1px solid CanvasText;
3535
}
3636
<%
3737
}

‎ua/org.eclipse.help.webapp/advanced/printAlert.css‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,18 @@ body{
2323

2424
#titleText {
2525
font-weight:bold;
26-
color:WindowText;
26+
color:CanvasText;
2727
}
2828

2929
.printAlertDiv {
3030
width:400px;
31-
border:1px solid ThreeDShadow;
31+
border:1px solid CanvasText;
3232
background:button;
3333
}
3434

3535
.caption {
36-
background:ActiveCaption;
37-
color:CaptionText;
36+
background:Canvas;
37+
color:CanvasText;
3838
height: 30px;
3939
}
4040

‎ua/org.eclipse.help.webapp/advanced/quickSearch.jsp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ BODY {
3939
font:<%=prefs.getViewFont()%>;
4040
font-size:.875rem;
4141
background-color: <%=prefs.getToolbarBackground()%>;
42-
color:WindowText;
42+
color:CanvasText;
4343
}
4444
4545
TABLE {

‎ua/org.eclipse.help.webapp/advanced/searchList.css‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
body {
1616
<%=prefs.getViewBackgroundStyle()%>
17-
color: WindowText;
17+
color: CanvasText;
1818
font: <%=prefs.getViewFont()%>;
1919
font-size: .875rem;
2020
padding: 0px;
@@ -84,7 +84,7 @@ a:hover {
8484

8585
.unselectedMenuItem {
8686
background:<%=prefs.getToolbarBackground()%>;
87-
color:WindowText;
87+
color:CanvasText;
8888
padding-left:10px;
8989
padding-right:10px;
9090
}

‎ua/org.eclipse.help.webapp/advanced/searchScoped.jsp‎

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ INPUT {
6565
}
6666
6767
A {
68-
color:WindowText;
68+
color:CanvasText;
6969
text-decoration:none;
7070
}
7171
@@ -77,28 +77,18 @@ A {
7777
#searchWord {
7878
margin-left:5px;
7979
margin-right:5px;
80-
border:1px solid ThreeDShadow;
80+
border:1px solid CanvasText;
8181
}
8282
8383
#searchLabel {
84-
color:WindowText;
84+
color:CanvasText;
8585
}
8686
8787
#go {
88-
<%
89-
if (data.isMacMozilla()) {
90-
%>
91-
background:GrayText;
92-
<%
93-
} else {
94-
%>
95-
background:ThreeDShadow;
96-
<%
97-
}
98-
%>
99-
color:Window;
88+
background:CanvasText;
89+
color:Canvas;
10090
font-weight:bold;
101-
border:1px solid ThreeDShadow;
91+
border:1px solid CanvasText;
10292
margin-left:1px;
10393
font-size: 1.0em;
10494
}
@@ -114,7 +104,7 @@ A {
114104
text-align:<%=isRTL?"left":"right"%>;
115105
margin-<%=isRTL?"right":"left"%>:5px;
116106
border:0px;
117-
color:WindowText;
107+
color:CanvasText;
118108
text-decoration:none;
119109
}
120110

0 commit comments

Comments
 (0)