add rudimentary support for service configurables#249
add rudimentary support for service configurables#249features-not-bugs wants to merge 2 commits intoakyriako:mainfrom
Conversation
|
Hey @features-not-bugs , thanks for the PR. Please give me some context why you need these changes. because they are clashing with some design decisions of the operator:
|
|
Hey @akyriako, Thanks for getting back to this so fast. The overall idea here was to allow direct connection via the load balancer rather than requiring an Ingress/Gateway API stack to be deployed. For example in my specific situation, I have an 4 host Kubernetes cluster deployed in an offsite datacenter running cilium with full BGP meshing to a pair of routers. Each of these routers have a link to AWS where we run another Kubernetes cluster (mission critical). The way the network is setup is that we can access the resources of our datacenter Kubernetes cluster from AWS by simply connecting to the load balancer IP's. Adding in an Ingress/Gateway API for a service that will only be consumed from within our attached networks is just an extra step that isn't required in our use case. For point 2, I added this in as it made sense to simply group all service specific configuration in the service object with the idea that the root level service annotation object could be deprecated should you wish. Potentially going forward we can;
Let me know, thanks! |
Added in some basic configuration to the service spec for a typesense cluster.
I haven't worked with kubebuilder before so there may be an anti pattern or two in here.