Skip to content

fix: replace module-level SSLContext with verify=True to prevent event loop blocking #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegolameira wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −5
Open

fix: replace module-level SSLContext with verify=True to prevent event loop blocking #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions authcaptureproxy/auth_capture_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import re
from functools import partial
from json import JSONDecodeError
from ssl import SSLContext, create_default_context
from ssl import SSLContext
from typing import Any, Callable, Dict, List, Optional, Set, Text, Tuple, Union

import httpx
Expand All @@ -32,9 +32,6 @@
from authcaptureproxy.interceptor import BaseInterceptor, InterceptContext
from authcaptureproxy.stackoverflow import get_open_port

# Pre-configure SSL context
ssl_context = create_default_context()

_LOGGER = logging.getLogger(__name__)


Expand Down Expand Up @@ -63,7 +60,7 @@ def __init__(
"""
self._preserve_headers = preserve_headers
self.session_factory: Callable[[], httpx.AsyncClient] = session_factory or (
lambda: httpx.AsyncClient(verify=ssl_context)
lambda: httpx.AsyncClient(verify=True)
)
self.session: httpx.AsyncClient = session if session else self.session_factory()
self._proxy_url: URL = proxy_url
Expand Down
Loading