Skip to content

Commit 654d646

Browse files
coadometa-codesync[bot]
authored andcommitted
Exclude TinyMap and packAnimatedProps from the public C++ API (facebook#56292)
Summary: Pull Request resolved: facebook#56292 The TinyMap is a helper class under internal directory, not referenced anywhere in the snapshot, and considered unsafe (from the comment). It is not part of any module, so it is better to remove that from the snapshot. The `packAnimatedProps` method is used in `AnimationBackend` for translation from `AnimatedProps` to `folly::dynamic` and should not be used outside of React Native. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D98907855 fbshipit-source-id: e3a371cc088000a23f1ce1121fda808494979140
1 parent de78906 commit 654d646

File tree

7 files changed

+2
-84
lines changed

7 files changed

+2
-84
lines changed

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -306,17 +306,6 @@ struct pre_merge_jni_library {
306306
public int(*onload_func)(JNIEnv *, jclass);
307307
}
308308

309-
template <typename KeyT, typename ValueT>
310-
class TinyMap {
311-
public TinyMap::Iterator begin();
312-
public TinyMap::Iterator end();
313-
public TinyMap::Iterator find(KeyT key);
314-
public using Iterator = TinyMap::Pair*;
315-
public using Pair = std::pair<KeyT, ValueT>;
316-
public void erase(TinyMap::Iterator iterator);
317-
public void insert(TinyMap::Pair pair);
318-
}
319-
320309
union jvalue {
321310
public jboolean z;
322311
public jbyte b;
@@ -11404,9 +11393,6 @@ struct facebook::react::dom::RNMeasureRect {
1140411393
}
1140511394

1140611395

11407-
folly::dynamic facebook::react::animationbackend::packAnimatedProps(const facebook::react::AnimatedProps& animatedProps);
11408-
11409-
1141011396
static constexpr facebook::react::Tag facebook::react::animated::undefinedAnimatedNodeIdentifier;
1141111397

1141211398

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -306,17 +306,6 @@ struct pre_merge_jni_library {
306306
public int(*onload_func)(JNIEnv *, jclass);
307307
}
308308

309-
template <typename KeyT, typename ValueT>
310-
class TinyMap {
311-
public TinyMap::Iterator begin();
312-
public TinyMap::Iterator end();
313-
public TinyMap::Iterator find(KeyT key);
314-
public using Iterator = TinyMap::Pair*;
315-
public using Pair = std::pair<KeyT, ValueT>;
316-
public void erase(TinyMap::Iterator iterator);
317-
public void insert(TinyMap::Pair pair);
318-
}
319-
320309
union jvalue {
321310
public jboolean z;
322311
public jbyte b;
@@ -11260,9 +11249,6 @@ struct facebook::react::dom::RNMeasureRect {
1126011249
}
1126111250

1126211251

11263-
folly::dynamic facebook::react::animationbackend::packAnimatedProps(const facebook::react::AnimatedProps& animatedProps);
11264-
11265-
1126611252
static constexpr facebook::react::Tag facebook::react::animated::undefinedAnimatedNodeIdentifier;
1126711253

1126811254

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3637,17 +3637,6 @@ struct YGValue {
36373637
public float value;
36383638
}
36393639

3640-
template <typename KeyT, typename ValueT>
3641-
class TinyMap {
3642-
public TinyMap::Iterator begin();
3643-
public TinyMap::Iterator end();
3644-
public TinyMap::Iterator find(KeyT key);
3645-
public using Iterator = TinyMap::Pair*;
3646-
public using Pair = std::pair<KeyT, ValueT>;
3647-
public void erase(TinyMap::Iterator iterator);
3648-
public void insert(TinyMap::Pair pair);
3649-
}
3650-
36513640
template <typename T>
36523641
struct RCTRequired {
36533642
public RCTRequired& operator=(RCTRequired&&) = default;
@@ -13686,9 +13675,6 @@ facebook::jsi::Value facebook::react::TurboModuleConvertUtils::convertObjCObject
1368613675
id facebook::react::TurboModuleConvertUtils::convertJSIValueToObjCObject(facebook::jsi::Runtime& runtime, const facebook::jsi::Value& value, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker, BOOL useNSNull = NO);
1368713676

1368813677

13689-
folly::dynamic facebook::react::animationbackend::packAnimatedProps(const facebook::react::AnimatedProps& animatedProps);
13690-
13691-
1369213678
static const facebook::react::Color facebook::react::HostPlatformColor::UndefinedColor;
1369313679

1369413680

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3637,17 +3637,6 @@ struct YGValue {
36373637
public float value;
36383638
}
36393639

3640-
template <typename KeyT, typename ValueT>
3641-
class TinyMap {
3642-
public TinyMap::Iterator begin();
3643-
public TinyMap::Iterator end();
3644-
public TinyMap::Iterator find(KeyT key);
3645-
public using Iterator = TinyMap::Pair*;
3646-
public using Pair = std::pair<KeyT, ValueT>;
3647-
public void erase(TinyMap::Iterator iterator);
3648-
public void insert(TinyMap::Pair pair);
3649-
}
3650-
36513640
template <typename T>
36523641
struct RCTRequired {
36533642
public RCTRequired& operator=(RCTRequired&&) = default;
@@ -13552,9 +13541,6 @@ facebook::jsi::Value facebook::react::TurboModuleConvertUtils::convertObjCObject
1355213541
id facebook::react::TurboModuleConvertUtils::convertJSIValueToObjCObject(facebook::jsi::Runtime& runtime, const facebook::jsi::Value& value, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker, BOOL useNSNull = NO);
1355313542

1355413543

13555-
folly::dynamic facebook::react::animationbackend::packAnimatedProps(const facebook::react::AnimatedProps& animatedProps);
13556-
13557-
1355813544
static const facebook::react::Color facebook::react::HostPlatformColor::UndefinedColor;
1355913545

1356013546

scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,6 @@ struct YGValue {
1616
public float value;
1717
}
1818

19-
template <typename KeyT, typename ValueT>
20-
class TinyMap {
21-
public TinyMap::Iterator begin();
22-
public TinyMap::Iterator end();
23-
public TinyMap::Iterator find(KeyT key);
24-
public using Iterator = TinyMap::Pair*;
25-
public using Pair = std::pair<KeyT, ValueT>;
26-
public void erase(TinyMap::Iterator iterator);
27-
public void insert(TinyMap::Pair pair);
28-
}
29-
3019

3120
bool facebook::xplat::jsArgAsBool(const folly::dynamic& args, size_t n);
3221
double facebook::xplat::jsArgAsDouble(const folly::dynamic& args, size_t n);
@@ -8462,9 +8451,6 @@ struct facebook::react::dom::RNMeasureRect {
84628451
}
84638452

84648453

8465-
folly::dynamic facebook::react::animationbackend::packAnimatedProps(const facebook::react::AnimatedProps& animatedProps);
8466-
8467-
84688454
static constexpr facebook::react::Tag facebook::react::animated::undefinedAnimatedNodeIdentifier;
84698455

84708456

scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,6 @@ struct YGValue {
1616
public float value;
1717
}
1818

19-
template <typename KeyT, typename ValueT>
20-
class TinyMap {
21-
public TinyMap::Iterator begin();
22-
public TinyMap::Iterator end();
23-
public TinyMap::Iterator find(KeyT key);
24-
public using Iterator = TinyMap::Pair*;
25-
public using Pair = std::pair<KeyT, ValueT>;
26-
public void erase(TinyMap::Iterator iterator);
27-
public void insert(TinyMap::Pair pair);
28-
}
29-
3019

3120
bool facebook::xplat::jsArgAsBool(const folly::dynamic& args, size_t n);
3221
double facebook::xplat::jsArgAsDouble(const folly::dynamic& args, size_t n);
@@ -8453,9 +8442,6 @@ struct facebook::react::dom::RNMeasureRect {
84538442
}
84548443

84558444

8456-
folly::dynamic facebook::react::animationbackend::packAnimatedProps(const facebook::react::AnimatedProps& animatedProps);
8457-
8458-
84598445
static constexpr facebook::react::Tag facebook::react::animated::undefinedAnimatedNodeIdentifier;
84608446

84618447

scripts/cxx-api/config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ exclude_symbols:
1111
- "NativeReactNativeFeatureFlags"
1212
- "UnstableLegacy"
1313
- "Experimental"
14+
- "TinyMap"
15+
- "packAnimatedProps"
1416

1517
platforms:
1618
ReactCommon:

0 commit comments

Comments
 (0)