Cleanup legacy flow types in react-native (facebook#56300)

Summary:
Pull Request resolved: facebook#56300

Changelog: [Internal]

Reviewed By: marcoww6

Differential Revision: D99004126

fbshipit-source-id: dfedc13c867cb768777e2ba65256a2c40ffb1d08

Author: SamChou19815

jest.config.js

@@ -43,7 +43,7 @@ module.exports = {
     '<rootDir>/packages/react-native/Libraries/Renderer',
     '<rootDir>/packages/react-native/sdks/hermes/',
     ...PODS_LOCATIONS,
-  ] /*:: as $ReadOnlyArray<string> */,
+  ] /*:: as ReadonlyArray<string> */,
   transformIgnorePatterns: ['node_modules/(?!@react-native/)'],
   haste: {
     defaultPlatform: 'ios',
@@ -52,12 +52,12 @@ module.exports = {
   moduleFileExtensions: [
     'fb.js',
     ...defaults.moduleFileExtensions,
-  ] /*:: as $ReadOnlyArray<string> */,
+  ] /*:: as ReadonlyArray<string> */,
   modulePathIgnorePatterns: [
     'scripts/.*/__fixtures__/',
     '<rootDir>/packages/react-native/sdks/hermes/',
     ...PODS_LOCATIONS,
-  ] /*:: as $ReadOnlyArray<string> */,
+  ] /*:: as ReadonlyArray<string> */,
   unmockedModulePathPatterns: [
     'node_modules/react/',
     'packages/react-native/Libraries/Renderer',

packages/dev-middleware/src/__tests__/InspectorProxyCdpTransport-test.js

@@ -522,9 +522,9 @@ describe.each(['HTTP', 'HTTPS'])(
 
           // Collect all connect events
           const connectEvents: Array<
-            $ReadOnly<{
+            Readonly<{
               event: string,
-              payload: $ReadOnly<{pageId: string, sessionId?: string}>,
+              payload: Readonly<{pageId: string, sessionId?: string}>,
             }>,
           > = [];
           device.connect.mockImplementation(message => {

packages/dev-middleware/src/types/ReadonlyURL.js

@@ -25,7 +25,7 @@ export interface ReadonlyURLSearchParams {
       value: string,
       name: string,
       params: URLSearchParams,
-    ) => mixed,
+    ) => unknown,
     thisArg: This,
   ): void;
   toString(): string;

packages/react-native-babel-preset/src/__tests__/__fixtures__/kitchen-sink-input.js

@@ -59,7 +59,7 @@ async function* asyncNumberGenerator(
 }
 
 // Async/await patterns
-async function fetchData(url: string): Promise<{data: mixed}> {
+async function fetchData(url: string): Promise<{data: unknown}> {
   const response = await fetch(url);
   const data = await response.json();
   return {data};
@@ -159,7 +159,7 @@ function parseDate(
 }
 
 // Try-catch with optional binding
-function safeJsonParse(input: string): mixed {
+function safeJsonParse(input: string): unknown {
   try {
     return JSON.parse(input);
   } catch {
@@ -182,7 +182,7 @@ const MyClass = class {
 };
 
 // Dynamic import (syntax only)
-async function loadModule(): Promise<mixed> {
+async function loadModule(): Promise<unknown> {
   // $FlowExpectedError[cannot-resolve-module] - Testing dynamic import syntax
   const module = await import('./some-module');
   return module.default;

packages/react-native-babel-preset/src/__tests__/transform-snapshot-test.js

@@ -133,7 +133,7 @@ const testConfigs = [
 
 function transformCode(
   code: string,
-  options: {[string]: mixed},
+  options: {[string]: unknown},
 ): string | null {
   const result = babel.transformSync(code, {
     babelrc: false,
@@ -156,7 +156,7 @@ function ensureDirectoryExists(dir: string): void {
   }
 }
 
-function makeHeader(description: string, options: {[string]: mixed}): string {
+function makeHeader(description: string, options: {[string]: unknown}): string {
   return `/**
  * Copyright (c) Meta Platforms, Inc. and affiliates.
  *

packages/react-native-codegen/src/parsers/consistency/compareSnaps.js

@@ -11,13 +11,13 @@
 'use strict';
 
 function compareSnaps(
-  flowFixtures /*: $ReadOnly<{[string]: string}> */,
-  flowSnaps /*: $ReadOnly<{[string]: string}> */,
-  flowExtraCases /*: $ReadOnlyArray<string> */,
-  tsFixtures /*: $ReadOnly<{[string]: string}> */,
-  tsSnaps /*: $ReadOnly<{[string]: string}> */,
-  tsExtraCases /*: $ReadOnlyArray<string> */,
-  ignoredCases /*: $ReadOnlyArray<string> */,
+  flowFixtures /*: Readonly<{[string]: string}> */,
+  flowSnaps /*: Readonly<{[string]: string}> */,
+  flowExtraCases /*: ReadonlyArray<string> */,
+  tsFixtures /*: Readonly<{[string]: string}> */,
+  tsSnaps /*: Readonly<{[string]: string}> */,
+  tsExtraCases /*: ReadonlyArray<string> */,
+  ignoredCases /*: ReadonlyArray<string> */,
 ) {
   const flowCases = Object.keys(flowFixtures).sort();
   const tsCases = Object.keys(tsFixtures).sort();
@@ -68,8 +68,8 @@ function compareSnaps(
 }
 
 function compareTsArraySnaps(
-  tsSnaps /*: $ReadOnly<{[string]: string}> */,
-  tsExtraCases /*: $ReadOnlyArray<string> */,
+  tsSnaps /*: Readonly<{[string]: string}> */,
+  tsExtraCases /*: ReadonlyArray<string> */,
 ) {
   for (const array2Case of tsExtraCases.filter(
     name => name.indexOf('ARRAY2') !== -1,

packages/react-native-compatibility-check/src/ErrorFormatting.js

@@ -199,7 +199,7 @@ function formatTypeAnnotation(annotation: CompleteTypeAnnotation): string {
       let validUnionType;
       try {
         validUnionType = parseValidUnionType(annotation);
-      } catch (_e: mixed) {
+      } catch (_e: unknown) {
         // parseValidUnionType throws for unsupported union types
         return 'Union<mixed>';
       }

packages/react-native/Libraries/Components/AccessibilityInfo/__tests__/AccessibilityInfo-test.js

@@ -105,7 +105,7 @@ describe('AccessibilityInfo', () => {
         mockNativeAccessibilityManagerDefault.getCurrentPrefersCrossFadeTransitionsState =
           null;
 
-        const result: mixed =
+        const result: unknown =
           await AccessibilityInfo.prefersCrossFadeTransitions().catch(e => e);
 
         invariant(
@@ -151,7 +151,7 @@ describe('AccessibilityInfo', () => {
         mockNativeAccessibilityManagerDefault.getCurrentDarkerSystemColorsState =
           null;
 
-        const result: mixed =
+        const result: unknown =
           await AccessibilityInfo.isDarkerSystemColorsEnabled().catch(e => e);
 
         invariant(
@@ -184,7 +184,7 @@ describe('AccessibilityInfo', () => {
 
         mockNativeAccessibilityInfo.isHighTextContrastEnabled = null;
 
-        const result: mixed =
+        const result: unknown =
           await AccessibilityInfo.isHighTextContrastEnabled().catch(e => e);
 
         invariant(

packages/react-native/Libraries/Core/Devtools/__tests__/loadBundleFromServer-test.js

@@ -95,7 +95,7 @@ test('loadBundleFromServer will throw for JSON responses', async () => {
   mockDataResponse = JSON.stringify({message: 'Error thrown from Metro'});
   mockRequestError = null;
 
-  const error: mixed = await loadBundleFromServer(
+  const error: unknown = await loadBundleFromServer(
     '/Fail.bundle?platform=ios',
   ).catch(e => e);
 
@@ -112,7 +112,7 @@ test('loadBundleFromServer will throw LoadBundleFromServerError for request erro
   mockDataResponse = '';
   mockRequestError = 'Some error';
 
-  const error: mixed = await loadBundleFromServer(
+  const error: unknown = await loadBundleFromServer(
     '/Fail.bundle?platform=ios',
   ).catch(e => e);
 

packages/react-native/cli.js

@@ -47,7 +47,7 @@ function isMissingCliDependency(error /*: Error */) {
   );
 }
 
-let cli /*: $ReadOnly<{
+let cli /*: Readonly<{
   bin: string,
   loadConfig: $FlowFixMe,
   run: () => void