Skip to content

Commit de78906

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Register VirtualView component (facebook#56289)
Summary: Pull Request resolved: facebook#56289 Changelog: [GENERAL][FIXED] Link VirtualView component I saw D98039999 and I wanted to check how the new components are working in OSS, and currently they don't. VirtualView component isn't correctly linked in OSS. This diff addresses that. Note that VirtualView in OSS requires `babel-plugin-transform-flow-enums` which is not part of the default template. Reviewed By: CalixTang Differential Revision: D98887952 fbshipit-source-id: f06ec9d4581c6fa3f2185641cb4b9f7acb8f557e
1 parent 82bffce commit de78906

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

packages/react-native/React/Fabric/Mounting/ComponentViews/RCTFabricComponentsPlugins.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ Class<RCTComponentViewProtocol> RCTSwitchCls(void) __attribute__((used));
4040
Class<RCTComponentViewProtocol> RCTTextInputCls(void) __attribute__((used));
4141
Class<RCTComponentViewProtocol> RCTUnimplementedNativeViewCls(void) __attribute__((used));
4242
Class<RCTComponentViewProtocol> RCTViewCls(void) __attribute__((used));
43+
Class<RCTComponentViewProtocol> VirtualViewCls(void) __attribute__((used));
4344
Class<RCTComponentViewProtocol> RCTImageCls(void) __attribute__((used));
4445
Class<RCTComponentViewProtocol> RCTModalHostViewCls(void) __attribute__((used));
4546

packages/react-native/React/Fabric/Mounting/ComponentViews/RCTFabricComponentsPlugins.mm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
{"TextInput", RCTTextInputCls},
3030
{"UnimplementedNativeView", RCTUnimplementedNativeViewCls},
3131
{"View", RCTViewCls},
32+
{"VirtualView", VirtualViewCls},
3233
{"Image", RCTImageCls},
3334
{"ModalHostView", RCTModalHostViewCls},
3435
};

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ import com.facebook.react.views.text.SelectableTextViewManager
6363
import com.facebook.react.views.textinput.ReactTextInputManager
6464
import com.facebook.react.views.unimplementedview.ReactUnimplementedViewManager
6565
import com.facebook.react.views.view.ReactViewManager
66+
import com.facebook.react.views.virtual.view.ReactVirtualViewManager
6667

6768
/**
6869
* Package defining basic modules and view managers.
@@ -155,6 +156,7 @@ constructor(private val config: MainPackageConfig? = null) :
155156
else ReactTextViewManager(),
156157
SelectableTextViewManager(),
157158
ReactViewManager(),
159+
ReactVirtualViewManager(),
158160
ReactUnimplementedViewManager(),
159161
)
160162

@@ -199,6 +201,8 @@ constructor(private val config: MainPackageConfig? = null) :
199201
SelectableTextViewManager.REACT_CLASS to
200202
ModuleSpec.viewManagerSpec { SelectableTextViewManager() },
201203
ReactViewManager.REACT_CLASS to ModuleSpec.viewManagerSpec { ReactViewManager() },
204+
ReactVirtualViewManager.REACT_CLASS to
205+
ModuleSpec.viewManagerSpec { ReactVirtualViewManager() },
202206
ReactUnimplementedViewManager.REACT_CLASS to
203207
ModuleSpec.viewManagerSpec { ReactUnimplementedViewManager() },
204208
)

packages/react-native/ReactCommon/React-FabricComponents.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ Pod::Spec.new do |s|
148148
end
149149

150150
ss.subspec "virtualview" do |sss|
151-
sss.source_files = "react/renderer/components/virtualview/**/*.{m,mm,cpp,h}"
151+
sss.source_files = podspec_sources("react/renderer/components/virtualview/**/*.{m,mm,cpp,h}", "react/renderer/components/virtualview/**/*.h")
152152
sss.exclude_files = "react/renderer/components/virtualview/tests"
153153
sss.header_dir = "react/renderer/components/virtualview"
154154
end

0 commit comments

Comments
 (0)