[codex] Add legacy OS name lint rule#341
Conversation
🦋 Changeset detectedLatest commit: a4a15ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
More reviews will be available in 41 minutes and 26 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new Changesno-legacy-os-names lint rule
Sequence DiagramsequenceDiagram
participant RemarkProcessor
participant noLegacyOSNames
participant StringTraversal as visitParents<br/>(string nodes)
participant JSXTraversal as visitParents<br/>(mdxJsx elements)
participant VFile
RemarkProcessor->>noLegacyOSNames: invoke rule on AST root
noLegacyOSNames->>StringTraversal: walk root for string-valued nodes
StringTraversal->>StringTraversal: test node.value against LEGACY_OS_NAME_REGEX
StringTraversal->>VFile: message(match) with node.position
noLegacyOSNames->>JSXTraversal: walk root for mdxJsxFlowElement/TextElement
JSXTraversal->>JSXTraversal: iterate attributes, extract string values
JSXTraversal->>JSXTraversal: test attribute value against LEGACY_OS_NAME_REGEX
JSXTraversal->>VFile: message(match) with attribute.position
noLegacyOSNames->>RemarkProcessor: return rule result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
c75c6d6 to
648843e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 52.93% 53.88% +0.94%
==========================================
Files 60 61 +1
Lines 1483 1520 +37
Branches 460 471 +11
==========================================
+ Hits 785 819 +34
- Misses 539 542 +3
Partials 159 159 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
New Features
Tests
Chores
vendordirectory.Release