BUG: Use std::forward instead of std::move on forwarding references

Warns if std::move is applied to a forwarding reference (a T&& parameter
where T is a deduced template type). In such cases std::forward should be
used instead, to preserve the value category of the argument.

Author: hjmjohnson

Modules/Core/Common/test/itkArray2DGTest.cxx

@@ -70,7 +70,7 @@ TEST(Array2D, MoveConstruct)
     const auto * const * const originalDataArray{ original.data_array() };
     const unsigned int         originalSize{ original.size() };
 
-    const auto moveConstructed = std::move(original);
+    const auto moveConstructed = std::forward<decltype(original)>(original);
 
     // After the "move", the move-constructed object has retrieved the original data.
     EXPECT_EQ(moveConstructed.data_array(), originalDataArray);

Modules/Core/Common/test/itkRangeGTestUtilities.h

@@ -94,7 +94,7 @@ class RangeGTestUtilities
   ExpectMoveConstructedRangeHasSameIteratorsAsOriginalBeforeMove(TRange && originalRange)
   {
     const TRange originalRangeBeforeMove = originalRange;
-    TRange       moveConstructedRange(std::move(originalRange));
+    TRange       moveConstructedRange(std::forward<TRange>(originalRange));
 
     ExpectRangesHaveEqualBeginAndEnd(moveConstructedRange, originalRangeBeforeMove);
   }
@@ -107,7 +107,7 @@ class RangeGTestUtilities
     const TRange originalRangeBeforeMove = originalRange;
 
     TRange moveAssignedRange;
-    moveAssignedRange = std::move(originalRange);
+    moveAssignedRange = std::forward<TRange>(originalRange);
 
     ExpectRangesHaveEqualBeginAndEnd(moveAssignedRange, originalRangeBeforeMove);
   }