Skip to content

Commit 151d64f

Browse files
authored
Merge pull request InsightSoftwareConsortium#5989 from N-Dekker/Remove-local-type-aliases-Image-Iterators
Remove local type aliases of Image Iterators in `*.hxx`, use CTAD
2 parents aeec98c + dbab3e0 commit 151d64f

29 files changed

+58
-64
lines changed

Modules/Core/Common/include/itkImageAlgorithm.hxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ ImageAlgorithm::ReferenceCopy(const InputImageType * inIma
3636
{
3737
if (inRegion.GetSize()[0] == outRegion.GetSize()[0])
3838
{
39-
ImageScanlineConstIterator<InputImageType> it(inImage, inRegion);
40-
ImageScanlineIterator ot(outImage, outRegion);
39+
ImageScanlineConstIterator it(inImage, inRegion);
40+
ImageScanlineIterator ot(outImage, outRegion);
4141

4242
while (!it.IsAtEnd())
4343
{

Modules/Core/Transform/include/itkBSplineDeformableTransform.hxx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -496,13 +496,12 @@ BSplineDeformableTransform<TParametersValueType, VDimension, VSplineOrder>::Tran
496496

497497
outputPoint.Fill(ScalarType{});
498498

499-
using IteratorType = ImageScanlineConstIterator<ImageType>;
500-
IteratorType coeffIterator[SpaceDimension];
501-
unsigned long counter = 0;
502-
const ParametersValueType * basePointer = this->m_CoefficientImages[0]->GetBufferPointer();
499+
ImageScanlineConstIterator<ImageType> coeffIterator[SpaceDimension];
500+
unsigned long counter = 0;
501+
const ParametersValueType * basePointer = this->m_CoefficientImages[0]->GetBufferPointer();
503502
for (unsigned int j = 0; j < SpaceDimension; ++j)
504503
{
505-
coeffIterator[j] = IteratorType(this->m_CoefficientImages[j], supportRegion);
504+
coeffIterator[j] = ImageScanlineConstIterator(this->m_CoefficientImages[j], supportRegion);
506505
}
507506

508507
while (!coeffIterator[0].IsAtEnd())

Modules/Core/Transform/include/itkBSplineTransform.hxx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -540,13 +540,12 @@ BSplineTransform<TParametersValueType, VDimension, VSplineOrder>::TransformPoint
540540

541541
outputPoint.Fill(ScalarType{});
542542

543-
using IteratorType = ImageScanlineConstIterator<ImageType>;
544-
IteratorType coeffIterator[SpaceDimension];
545-
unsigned long counter = 0;
546-
const ParametersValueType * basePointer = this->m_CoefficientImages[0]->GetBufferPointer();
543+
ImageScanlineConstIterator<ImageType> coeffIterator[SpaceDimension];
544+
unsigned long counter = 0;
545+
const ParametersValueType * basePointer = this->m_CoefficientImages[0]->GetBufferPointer();
547546
for (unsigned int j = 0; j < SpaceDimension; ++j)
548547
{
549-
coeffIterator[j] = IteratorType(this->m_CoefficientImages[j], supportRegion);
548+
coeffIterator[j] = ImageScanlineConstIterator(this->m_CoefficientImages[j], supportRegion);
550549
}
551550

552551
while (!coeffIterator[0].IsAtEnd())

Modules/Filtering/BinaryMathematicalMorphology/include/itkBinaryMorphologyImageFilter.hxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ BinaryMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::AnalyzeKernel()
115115

116116
// copy
117117
ImageRegionIterator<BoolImageType> kernelImageIt; // iterator on image
118-
kernelImageIt = ImageRegionIterator<BoolImageType>(tmpSEImage, tmpSEImage->GetRequestedRegion());
118+
kernelImageIt = ImageRegionIterator(tmpSEImage, tmpSEImage->GetRequestedRegion());
119119

120120
kernel_it = KernelBegin;
121121

Modules/Filtering/BinaryMathematicalMorphology/include/itkObjectMorphologyImageFilter.hxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ ObjectMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::BeforeThreadedG
9898

9999
const RegionType requestedRegion = this->GetOutput()->GetRequestedRegion();
100100

101-
auto iRegIter = ImageRegionConstIterator<InputImageType>(this->GetInput(), requestedRegion);
102-
auto oRegIter = ImageRegionIterator<OutputImageType>(this->GetOutput(), requestedRegion);
101+
auto iRegIter = ImageRegionConstIterator(this->GetInput(), requestedRegion);
102+
auto oRegIter = ImageRegionIterator(this->GetOutput(), requestedRegion);
103103
/* Copy the input image to the output image - then only boundary pixels
104104
* need to be changed in the output image */
105105
while (!oRegIter.IsAtEnd())

Modules/Filtering/DisplacementField/include/itkDisplacementFieldJacobianDeterminantFilter.hxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ DisplacementFieldJacobianDeterminantFilter<TInputImage, TRealType, TOutputImage>
189189
{
190190
bit = ConstNeighborhoodIteratorType(
191191
m_NeighborhoodRadius, dynamic_cast<const RealVectorImageType *>(m_RealValuedInputImage.GetPointer()), face);
192-
it = ImageRegionIterator<TOutputImage>(this->GetOutput(), face);
192+
it = ImageRegionIterator(this->GetOutput(), face);
193193
bit.OverrideBoundaryCondition(&nbc);
194194
bit.GoToBegin();
195195

Modules/Filtering/ImageCompare/include/itkSTAPLEImageFilter.hxx

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ STAPLEImageFilter<TInputImage, TOutputImage>::GenerateData()
4949
{
5050
constexpr double epsilon{ 1.0e-10 };
5151

52-
using IteratorType = ImageScanlineConstIterator<TInputImage>;
53-
using FuzzyIteratorType = ImageScanlineIterator<TOutputImage>;
5452

5553
constexpr double min_rms_error{ 1.0e-14 }; // 7 digits of precision
5654

@@ -65,7 +63,7 @@ STAPLEImageFilter<TInputImage, TOutputImage>::GenerateData()
6563
// Record the number of input files.
6664
const ProcessObject::DataObjectPointerArraySizeType number_of_input_files = this->GetNumberOfIndexedInputs();
6765

68-
const auto D_it = make_unique_for_overwrite<IteratorType[]>(number_of_input_files);
66+
const auto D_it = make_unique_for_overwrite<ImageScanlineConstIterator<TInputImage>[]>(number_of_input_files);
6967

7068
const auto p = make_unique_for_overwrite<double[]>(number_of_input_files); // sensitivity
7169
const auto q = make_unique_for_overwrite<double[]>(number_of_input_files); // specificity
@@ -88,8 +86,8 @@ STAPLEImageFilter<TInputImage, TOutputImage>::GenerateData()
8886
itkExceptionStringMacro("One or more input images do not contain matching RequestedRegions");
8987
}
9088

91-
IteratorType in(this->GetInput(i), W->GetRequestedRegion());
92-
FuzzyIteratorType out(W, W->GetRequestedRegion());
89+
ImageScanlineConstIterator in(this->GetInput(i), W->GetRequestedRegion());
90+
ImageScanlineIterator out(W, W->GetRequestedRegion());
9391

9492
while (!in.IsAtEnd())
9593
{
@@ -112,7 +110,7 @@ STAPLEImageFilter<TInputImage, TOutputImage>::GenerateData()
112110
double N = 0.0;
113111
double g_t = 0.0;
114112
{
115-
FuzzyIteratorType out(W, W->GetRequestedRegion());
113+
ImageScanlineIterator out(W, W->GetRequestedRegion());
116114
while (!out.IsAtEnd())
117115
{
118116
while (!out.IsAtEndOfLine())
@@ -132,8 +130,8 @@ STAPLEImageFilter<TInputImage, TOutputImage>::GenerateData()
132130
// Now iterate on estimating specificity and sensitivity
133131
for (unsigned int i = 0; i < number_of_input_files; ++i)
134132
{
135-
IteratorType in(this->GetInput(i), W->GetRequestedRegion());
136-
FuzzyIteratorType out(W, W->GetRequestedRegion());
133+
ImageScanlineConstIterator in(this->GetInput(i), W->GetRequestedRegion());
134+
ImageScanlineIterator out(W, W->GetRequestedRegion());
137135

138136
double p_num{};
139137
double p_denom{};
@@ -172,10 +170,10 @@ STAPLEImageFilter<TInputImage, TOutputImage>::GenerateData()
172170
// segmentation
173171
for (unsigned int i = 0; i < number_of_input_files; ++i)
174172
{
175-
D_it[i] = IteratorType(this->GetInput(i), W->GetRequestedRegion());
173+
D_it[i] = ImageScanlineConstIterator(this->GetInput(i), W->GetRequestedRegion());
176174
}
177175

178-
FuzzyIteratorType out(W, W->GetRequestedRegion());
176+
ImageScanlineIterator out(W, W->GetRequestedRegion());
179177
while (!out.IsAtEnd())
180178
{
181179
while (!out.IsAtEndOfLine())

Modules/Filtering/ImageFeature/include/itkCannyEdgeDetectionImageFilter.hxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ CannyEdgeDetectionImageFilter<TInputImage, TOutputImage>::ThreadedCompute2ndDeri
118118
{
119119
NeighborhoodType bit(radius, input, face);
120120

121-
it = ImageRegionIterator<OutputImageType>(this->m_OutputImage, face);
121+
it = ImageRegionIterator(this->m_OutputImage, face);
122122
bit.OverrideBoundaryCondition(&nbc);
123123
bit.GoToBegin();
124124

@@ -416,7 +416,7 @@ CannyEdgeDetectionImageFilter<TInputImage, TOutputImage>::ThreadedCompute2ndDeri
416416
{
417417
bit = ConstNeighborhoodIterator<InputImageType>(radius, input, face);
418418
bit1 = ConstNeighborhoodIterator<InputImageType>(radius, input1, face);
419-
it = ImageRegionIterator<OutputImageType>(output, face);
419+
it = ImageRegionIterator(output, face);
420420
bit.OverrideBoundaryCondition(&nbc);
421421
bit.GoToBegin();
422422
bit1.GoToBegin();

Modules/Filtering/ImageFeature/include/itkHessian3DToVesselnessMeasureImageFilter.hxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Hessian3DToVesselnessMeasureImageFilter<TPixel>::GenerateData()
5555
ImageRegionConstIterator it(eigenImage, eigenImage->GetRequestedRegion());
5656
ImageRegionIterator<OutputImageType> oit;
5757
this->AllocateOutputs();
58-
oit = ImageRegionIterator<OutputImageType>(output, output->GetRequestedRegion());
58+
oit = ImageRegionIterator(output, output->GetRequestedRegion());
5959
while (!it.IsAtEnd())
6060
{
6161
// Get the eigen value

Modules/Filtering/ImageFeature/include/itkMultiScaleHessianBasedMeasureImageFilter.hxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,12 @@ MultiScaleHessianBasedMeasureImageFilter<TInputImage, THessianImage, TOutputImag
224224

225225
if (m_GenerateScalesOutput)
226226
{
227-
osit = ImageRegionIterator<ScalesImageType>(scalesImage, outputRegion);
227+
osit = ImageRegionIterator(scalesImage, outputRegion);
228228
osit.GoToBegin();
229229
}
230230
if (m_GenerateHessianOutput)
231231
{
232-
ohit = ImageRegionIterator<HessianImageType>(hessianImage, outputRegion);
232+
ohit = ImageRegionIterator(hessianImage, outputRegion);
233233
ohit.GoToBegin();
234234
}
235235

0 commit comments

Comments
 (0)