Skip to content

Commit 4a7710e

Browse files
authored
Merge pull request InsightSoftwareConsortium#5885 from hjmjohnson/convert-itkdecoratortest-to-itkdecoratorgtest
ENH: Convert itkDecoratorTest to itkDecoratorGTest
2 parents 1641908 + 86c0d29 commit 4a7710e

2 files changed

Lines changed: 12 additions & 21 deletions

File tree

Modules/Core/Common/test/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ set(
66
itkCommandObserverObjectTest.cxx
77
itkAdaptorComparisonTest.cxx
88
itkCovariantVectorGeometryTest.cxx
9-
itkDecoratorTest.cxx
109
itkExtractImage3Dto2DTest.cxx
1110
itkExtractImageTest.cxx
1211
itkFilterDispatchTest.cxx
@@ -298,12 +297,6 @@ itk_add_test(
298297
ITKCommon1TestDriver
299298
itkCovariantVectorGeometryTest
300299
)
301-
itk_add_test(
302-
NAME itkDecoratorTest
303-
COMMAND
304-
ITKCommon1TestDriver
305-
itkDecoratorTest
306-
)
307300
itk_add_test(
308301
NAME itkExtractImage3Dto2DTest
309302
COMMAND
@@ -1787,6 +1780,7 @@ set(
17871780
itkAnatomicalOrientationGTest.cxx
17881781
itkAutoPointerGTest.cxx
17891782
itkStdStreamStateSaveGTest.cxx
1783+
itkDecoratorGTest.cxx
17901784
)
17911785
creategoogletestdriver(ITKCommon "${ITKCommon-Test_LIBRARIES}" "${ITKCommonGTests}")
17921786
# If `-static` was passed to CMAKE_EXE_LINKER_FLAGS, compilation fails. No need to

Modules/Core/Common/test/itkDecoratorTest.cxx renamed to Modules/Core/Common/test/itkDecoratorGTest.cxx

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include "itkSimpleDataObjectDecorator.h"
2222
#include "itkDataObjectDecorator.h"
2323
#include "itkAutoPointerDataObjectDecorator.h"
24-
#include "itkTestingMacros.h"
24+
#include "itkGTest.h"
2525

2626
namespace
2727
{
@@ -34,10 +34,8 @@ operator<<(std::basic_ostream<CharType, TraitsType> & os, const std::vector<Memb
3434
}
3535
} // namespace
3636

37-
int
38-
itkDecoratorTest(int, char *[])
37+
TEST(Decorator, ConvertedLegacyTest)
3938
{
40-
4139
using FloatObjectType = itk::SimpleDataObjectDecorator<float>;
4240

4341
auto f = FloatObjectType::New();
@@ -59,16 +57,16 @@ itkDecoratorTest(int, char *[])
5957

6058
const itk::ModifiedTimeType t1 = decoratedTransform->GetMTime();
6159
transformObject->Modified();
62-
ITK_TEST_EXPECT_TRUE(t1 < decoratedTransform->GetMTime());
60+
EXPECT_GT(decoratedTransform->GetMTime(), t1);
6361

6462
auto decoratedTransform2 = TransformObjectType::New();
6563
decoratedTransform2->Graft(decoratedTransform);
6664

67-
ITK_TEST_EXPECT_EQUAL(decoratedTransform2->Get(), decoratedTransform->Get());
65+
EXPECT_EQ(decoratedTransform2->Get(), decoratedTransform->Get());
6866

6967
const itk::ModifiedTimeType t2 = decoratedTransform->GetMTime();
7068
decoratedTransform2->GetModifiable()->Modified();
71-
ITK_TEST_EXPECT_TRUE(t2 < decoratedTransform->GetMTime());
69+
EXPECT_GT(decoratedTransform->GetMTime(), t2);
7270

7371

7472
std::cout << "Value of decoratedTransform: ";
@@ -81,25 +79,25 @@ itkDecoratorTest(int, char *[])
8179
auto decoratedBaseTransform = TransformBaseObjectType::New();
8280
// NOTE: GetPointer is needed to force selection of the correct overloaded function signature.
8381
decoratedBaseTransform->Graft(decoratedTransform.GetPointer());
84-
ITK_TEST_EXPECT_TRUE(decoratedBaseTransform->Get() != nullptr);
82+
EXPECT_TRUE(decoratedBaseTransform->Get() != nullptr);
8583

8684
decoratedBaseTransform->ReleaseData();
87-
ITK_TEST_EXPECT_TRUE(decoratedBaseTransform->Get() == nullptr);
85+
EXPECT_EQ(decoratedBaseTransform->Get(), nullptr);
8886
// NOTE: GetPointer is needed to force selection of the correct overloaded function signature.
8987
decoratedBaseTransform->Graft(f.GetPointer());
90-
ITK_TEST_EXPECT_TRUE(decoratedBaseTransform->Get() == nullptr);
88+
EXPECT_TRUE(decoratedBaseTransform->Get() == nullptr);
9189

9290
decoratedBaseTransform->Graft(static_cast<itk::DataObject *>(nullptr));
9391
// NOTE: GetPointer is needed to force selection of the correct overloaded function signature.
9492
decoratedBaseTransform->Graft(decoratedTransform.GetPointer());
95-
ITK_TEST_EXPECT_TRUE(decoratedBaseTransform->Get() != nullptr);
93+
EXPECT_NE(decoratedBaseTransform->Get(), nullptr);
9694

9795
decoratedBaseTransform->Graft(static_cast<itk::DataObject *>(nullptr));
98-
ITK_TEST_EXPECT_TRUE(decoratedBaseTransform->Get() != nullptr);
96+
EXPECT_TRUE(decoratedBaseTransform->Get() != nullptr);
9997

10098
decoratedTransform->ReleaseData();
10199
decoratedTransform->Graft(decoratedBaseTransform);
102-
ITK_TEST_EXPECT_TRUE(decoratedTransform->Get() == nullptr);
100+
EXPECT_TRUE(decoratedTransform->Get() == nullptr);
103101

104102
using VectorType = std::vector<float>;
105103
using VectorObjectType = itk::SimpleDataObjectDecorator<VectorType>;
@@ -149,5 +147,4 @@ itkDecoratorTest(int, char *[])
149147

150148

151149
std::cout << "Test finished." << std::endl;
152-
return EXIT_SUCCESS;
153150
}

0 commit comments

Comments
 (0)