STYLE: Remove GoToBegin() calls from Image Iterators in hxx files

N-Dekker · N-Dekker · commit b1162f4aa6ce · 2026-03-31T11:00:03.000+02:00
Their `IteratorType(image, region)` constructors do already initialize the iterator at the begin of its region. Using Notepad++, Replace in Files, doing: Find what: ^([ ]+)(Image\w+Iterator[ ]+)(\w+)(\(.*\);)[\r\n]+\1\3\.GoToBegin\(\); Filters: itk*.hxx [v] Match case (*) Regular expression [ ] . matches newline Follow-up to pull request InsightSoftwareConsortium#4830 commit cf57876 "STYLE: Remove unnecessary iterator `GoToBegin()` calls from Core"
diff --git a/Modules/Filtering/BiasCorrection/include/itkMRASlabIdentifier.hxx b/Modules/Filtering/BiasCorrection/include/itkMRASlabIdentifier.hxx
@@ -78,7 +78,6 @@ MRASlabIdentifier<TInputImage>::GenerateSlabRegions()
     region.SetIndex(index);
 
     ImageRegionConstIterator iter(m_Image, region);
-    iter.GoToBegin();
 
     std::priority_queue<ImagePixelType> mins;
     for (unsigned int i = 0; i < m_NumberOfSamples; ++i)
diff --git a/Modules/Filtering/BiasCorrection/include/itkMRIBiasFieldCorrectionFilter.hxx b/Modules/Filtering/BiasCorrection/include/itkMRIBiasFieldCorrectionFilter.hxx
@@ -102,7 +102,6 @@ MRIBiasEnergyFunction<TImage, TImageMask, TBiasField>::GetValue(const Parameters
     else
     {
       ImageRegionIterator mIter(m_Mask, m_Region);
-      mIter.GoToBegin();
       while (!bIter.IsAtEnd())
       {
         if (mIter.Get() > 0.0)
@@ -547,7 +546,6 @@ MRIBiasFieldCorrectionFilter<TInputImage, TOutputImage, TMaskImage>::CorrectImag
   {
     itkDebugMacro("Output mask is being used");
     ImageRegionIterator mIter(m_OutputMask, region);
-    mIter.GoToBegin();
     while (!bIter.IsAtEnd())
     {
       const double inputPixel = iIter.Get();
diff --git a/Modules/Filtering/ImageIntensity/include/itkDiscreteGaussianDerivativeImageFunction.hxx b/Modules/Filtering/ImageIntensity/include/itkDiscreteGaussianDerivativeImageFunction.hxx
@@ -136,8 +136,7 @@ DiscreteGaussianDerivativeImageFunction<TInputImage, TOutput>::RecomputeGaussian
 
   // Copy kernel image to neighborhood. Do not copy boundaries.
   ImageRegionConstIterator it(kernelImage, kernelRegion);
-  it.GoToBegin();
-  unsigned int idx = 0;
+  unsigned int             idx = 0;
 
   while (!it.IsAtEnd())
   {
diff --git a/Modules/Filtering/ImageIntensity/include/itkDiscreteGradientMagnitudeGaussianImageFunction.hxx b/Modules/Filtering/ImageIntensity/include/itkDiscreteGradientMagnitudeGaussianImageFunction.hxx
@@ -158,8 +158,7 @@ DiscreteGradientMagnitudeGaussianImageFunction<TInputImage, TOutput>::RecomputeG
 
     // Copy kernel image to neighborhood. Do not copy boundaries.
     ImageRegionConstIterator it(kernelImage, kernelRegion);
-    it.GoToBegin();
-    unsigned int idx = 0;
+    unsigned int             idx = 0;
 
     while (!it.IsAtEnd())
     {
diff --git a/Modules/Filtering/ImageIntensity/include/itkDiscreteHessianGaussianImageFunction.hxx b/Modules/Filtering/ImageIntensity/include/itkDiscreteHessianGaussianImageFunction.hxx
@@ -164,8 +164,7 @@ DiscreteHessianGaussianImageFunction<TInputImage, TOutput>::RecomputeGaussianKer
 
       // Copy kernel image to neighborhood. Do not copy boundaries.
       ImageRegionConstIterator it(kernelImage, kernelRegion);
-      it.GoToBegin();
-      unsigned int idx = 0;
+      unsigned int             idx = 0;
       while (!it.IsAtEnd())
       {
         m_KernelArray[kernelidx][idx] = it.Get();
diff --git a/Modules/Filtering/ImageIntensity/include/itkHistogramMatchingImageFilter.hxx b/Modules/Filtering/ImageIntensity/include/itkHistogramMatchingImageFilter.hxx
@@ -437,8 +437,6 @@ HistogramMatchingImageFilter<TInputImage, TOutputImage, THistogramMeasurement>::
   {
     // put each image pixel into the histogram
     ImageRegionConstIterator iter(image, image->GetBufferedRegion());
-
-    iter.GoToBegin();
     while (!iter.IsAtEnd())
     {
       const InputPixelType & value = iter.Value();
diff --git a/Modules/Filtering/ImageStatistics/include/itkAccumulateImageFilter.hxx b/Modules/Filtering/ImageStatistics/include/itkAccumulateImageFilter.hxx
@@ -181,8 +181,7 @@ AccumulateImageFilter<TInputImage, TOutputImage>::GenerateData()
     }
     const typename TInputImage::RegionType AccumulatedRegion(AccumulatedIndex, AccumulatedSize);
     ImageRegionConstIterator               inputIter(inputImage, AccumulatedRegion);
-    inputIter.GoToBegin();
-    AccumulateType Value{};
+    AccumulateType                         Value{};
     while (!inputIter.IsAtEnd())
     {
       Value += static_cast<AccumulateType>(inputIter.Get());
diff --git a/Modules/Filtering/ImageStatistics/include/itkImagePCAShapeModelEstimator.hxx b/Modules/Filtering/ImageStatistics/include/itkImagePCAShapeModelEstimator.hxx
@@ -166,8 +166,6 @@ ImagePCAShapeModelEstimator<TInputImage, TOutputImage>::GenerateData()
   {
     region = this->GetOutput(j)->GetRequestedRegion();
     ImageRegionIterator outIterJ(this->GetOutput(j), region);
-
-    outIterJ.GoToBegin();
     while (!outIterJ.IsAtEnd())
     {
       outIterJ.Set(0);
diff --git a/Modules/Filtering/LabelMap/include/itkLabelMapToBinaryImageFilter.hxx b/Modules/Filtering/LabelMap/include/itkLabelMapToBinaryImageFilter.hxx
@@ -123,7 +123,6 @@ LabelMapToBinaryImageFilter<TInputImage, TOutputImage>::DynamicThreadedGenerateD
   {
     // fill the background with the background value
     ImageRegionIterator oIt(output, outputRegionForThread);
-    oIt.GoToBegin();
 
     while (!oIt.IsAtEnd())
     {
diff --git a/Modules/Filtering/Smoothing/include/itkBinomialBlurImageFilter.hxx b/Modules/Filtering/Smoothing/include/itkBinomialBlurImageFilter.hxx
@@ -184,8 +184,6 @@ BinomialBlurImageFilter<TInputImage, TOutputImage>::GenerateData()
       //----------------------Reverse pass----------------------
       ImageRegionReverseIterator tempReverseIt(tempPtr, tempPtr->GetRequestedRegion());
 
-      tempReverseIt.GoToBegin();
-
       while (!tempReverseIt.IsAtEnd())
       {
         // determine the index of the output pixel
diff --git a/Modules/Nonunit/Review/include/itkAttributeMorphologyBaseImageFilter.hxx b/Modules/Nonunit/Review/include/itkAttributeMorphologyBaseImageFilter.hxx
@@ -173,7 +173,6 @@ AttributeMorphologyBaseImageFilter<TInputImage, TOutputImage, TAttribute, TFunct
   // resolving phase
   // copy pixels back
   ImageRegionIterator ORegIt(output, output->GetRequestedRegion());
-  ORegIt.GoToBegin();
 
   // fill Raw - worry about iteration details later.
   // We aren't filling m_Parent, as suggested in the paper, because it
diff --git a/Modules/Nonunit/Review/include/itkMultiphaseSparseFiniteDifferenceImageFilter.hxx b/Modules/Nonunit/Review/include/itkMultiphaseSparseFiniteDifferenceImageFilter.hxx
@@ -1015,8 +1015,6 @@ MultiphaseSparseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputI
       // For each region, set the pixel in m_StatusImage to
       // m_StatusBoundaryPixel
       ImageRegionIterator statusIt(sparsePtr->m_StatusImage, *fit);
-
-      statusIt.GoToBegin();
       while (!statusIt.IsAtEnd())
       {
         statusIt.Set(m_StatusBoundaryPixel);
@@ -1123,8 +1121,6 @@ MultiphaseSparseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputI
     ImageRegionConstIterator statusIt(sparsePtr->m_StatusImage, this->m_LevelSet[fId]->GetRequestedRegion());
 
     ImageRegionIterator outputIt(this->m_LevelSet[fId], this->m_LevelSet[fId]->GetRequestedRegion());
-
-    outputIt.GoToBegin();
     statusIt.GoToBegin();
 
     while (!outputIt.IsAtEnd())
diff --git a/Modules/Numerics/Statistics/include/itkImageToHistogramFilter.hxx b/Modules/Numerics/Statistics/include/itkImageToHistogramFilter.hxx
@@ -199,8 +199,7 @@ ImageToHistogramFilter<TImage>::ThreadedComputeMinimumAndMaximum(const RegionTyp
   HistogramMeasurementVectorType min(nbOfComponents);
   HistogramMeasurementVectorType max(nbOfComponents);
 
-  ImageRegionConstIterator inputIt(this->GetInput(), inputRegionForThread);
-  inputIt.GoToBegin();
+  ImageRegionConstIterator       inputIt(this->GetInput(), inputRegionForThread);
   HistogramMeasurementVectorType m(nbOfComponents);
 
   min.Fill(NumericTraits<ValueType>::max());
@@ -238,8 +237,7 @@ ImageToHistogramFilter<TImage>::ThreadedStreamedGenerateData(const RegionType &
   histogram->Initialize(outputHistogram->GetSize(), m_Minimum, m_Maximum);
 
 
-  ImageRegionConstIterator inputIt(this->GetInput(), inputRegionForThread);
-  inputIt.GoToBegin();
+  ImageRegionConstIterator       inputIt(this->GetInput(), inputRegionForThread);
   HistogramMeasurementVectorType m(nbOfComponents);
 
   typename HistogramType::IndexType index;
diff --git a/Modules/Numerics/Statistics/include/itkImageToListSampleFilter.hxx b/Modules/Numerics/Statistics/include/itkImageToListSampleFilter.hxx
@@ -125,12 +125,10 @@ ImageToListSampleFilter<TImage, TMaskImage>::GenerateData()
   output->Clear();
 
   ImageRegionConstIterator it(input, input->GetBufferedRegion());
-  it.GoToBegin();
 
   if (maskImage) // mask specified
   {
     ImageRegionConstIterator mit(maskImage, maskImage->GetBufferedRegion());
-    mit.GoToBegin();
     while (!it.IsAtEnd())
     {
       if (mit.Get() == this->m_MaskValue)
diff --git a/Modules/Registration/Common/include/itkHistogramImageToImageMetric.hxx b/Modules/Registration/Common/include/itkHistogramImageToImageMetric.hxx
@@ -89,9 +89,8 @@ HistogramImageToImageMetric<TFixedImage, TMovingImage>::Initialize()
     // Calculate min and max image values in fixed image.
     const FixedImageConstPointerType pFixedImage = this->m_FixedImage;
     ImageRegionConstIterator         fiIt(pFixedImage, pFixedImage->GetBufferedRegion());
-    fiIt.GoToBegin();
-    FixedImagePixelType minFixed = fiIt.Value();
-    FixedImagePixelType maxFixed = fiIt.Value();
+    FixedImagePixelType              minFixed = fiIt.Value();
+    FixedImagePixelType              maxFixed = fiIt.Value();
     ++fiIt;
     while (!fiIt.IsAtEnd())
     {
@@ -112,9 +111,8 @@ HistogramImageToImageMetric<TFixedImage, TMovingImage>::Initialize()
     // Calculate min and max image values in moving image.
     const MovingImageConstPointerType pMovingImage = this->m_MovingImage;
     ImageRegionConstIterator          miIt(pMovingImage, pMovingImage->GetBufferedRegion());
-    miIt.GoToBegin();
-    MovingImagePixelType minMoving = miIt.Value();
-    MovingImagePixelType maxMoving = miIt.Value();
+    MovingImagePixelType              minMoving = miIt.Value();
+    MovingImagePixelType              maxMoving = miIt.Value();
     ++miIt;
     while (!miIt.IsAtEnd())
     {
diff --git a/Modules/Registration/Metricsv4/include/itkJointHistogramMutualInformationComputeJointPDFThreaderBase.hxx b/Modules/Registration/Metricsv4/include/itkJointHistogramMutualInformationComputeJointPDFThreaderBase.hxx
@@ -125,7 +125,6 @@ JointHistogramMutualInformationComputeJointPDFThreaderBase<TDomainPartitioner,
   }
 
   ImageRegionIterator jointPDFIt(this->m_Associate->m_JointPDF, this->m_Associate->m_JointPDF->GetBufferedRegion());
-  jointPDFIt.GoToBegin();
   std::vector<ImageRegionConstIterator<JointHistogramType>> jointHistogramPerThreadIts;
   for (ThreadIdType i = 0; i < numberOfWorkUnitsUsed; ++i)
   {
diff --git a/Modules/Segmentation/Classifiers/include/itkBayesianClassifierImageFilter.hxx b/Modules/Segmentation/Classifiers/include/itkBayesianClassifierImageFilter.hxx
@@ -285,8 +285,6 @@ BayesianClassifierImageFilter<TInputVectorImage, TLabelsType, TPosteriorsPrecisi
 
       itrPosteriorImage.GoToBegin();
       ImageRegionIterator it(extractedComponentImage, extractedComponentImage->GetBufferedRegion());
-
-      it.GoToBegin();
       while (!itrPosteriorImage.IsAtEnd())
       {
         it.Set(itrPosteriorImage.Get()[componentToExtract]);
@@ -301,7 +299,6 @@ BayesianClassifierImageFilter<TInputVectorImage, TLabelsType, TPosteriorsPrecisi
       itrPosteriorImage.GoToBegin();
 
       ImageRegionIterator sit(m_SmoothingFilter->GetOutput(), m_SmoothingFilter->GetOutput()->GetBufferedRegion());
-      sit.GoToBegin();
       while (!itrPosteriorImage.IsAtEnd())
       {
         PosteriorsPixelType posteriorPixel = itrPosteriorImage.Get();
diff --git a/Modules/Segmentation/Classifiers/include/itkScalarImageKmeansImageFilter.hxx b/Modules/Segmentation/Classifiers/include/itkScalarImageKmeansImageFilter.hxx
@@ -161,7 +161,6 @@ ScalarImageKmeansImageFilter<TInputImage, TOutputImage>::GenerateData()
   }
 
   ImageRegionIterator pixel(outputPtr, region);
-  pixel.GoToBegin();
 
   using ClassifierOutputType = typename ClassifierType::MembershipSampleType;
   const ClassifierOutputType * membershipSample = classifier->GetOutput();
diff --git a/Modules/Segmentation/ConnectedComponents/include/itkConnectedComponentFunctorImageFilter.hxx b/Modules/Segmentation/ConnectedComponents/include/itkConnectedComponentFunctorImageFilter.hxx
@@ -98,8 +98,6 @@ ConnectedComponentFunctorImageFilter<TInputImage, TOutputImage, TFunctor, TMaskI
   if (const typename TMaskImage::ConstPointer mask = this->GetMaskImage())
   {
     ImageRegionConstIterator mit(mask, output->GetRequestedRegion());
-
-    mit.GoToBegin();
     oit.GoToBegin();
     while (!mit.IsAtEnd())
     {
diff --git a/Modules/Segmentation/Watersheds/include/itkWatershedSegmenter.hxx b/Modules/Segmentation/Watersheds/include/itkWatershedSegmenter.hxx
@@ -1017,7 +1017,6 @@ void
 Segmenter<TInputImage>::SetInputImageValues(InputImageTypePointer img, ImageRegionType region, InputPixelType value)
 {
   ImageRegionIterator it(img, region);
-  it.GoToBegin();
   while (!it.IsAtEnd())
   {
     it.Set(value);
@@ -1030,7 +1029,6 @@ void
 Segmenter<TInputImage>::SetOutputImageValues(OutputImageTypePointer img, ImageRegionType region, IdentifierType value)
 {
   ImageRegionIterator it(img, region);
-  it.GoToBegin();
   while (!it.IsAtEnd())
   {
     it.Set(value);
@@ -1046,7 +1044,6 @@ Segmenter<TInputImage>::MinMax(InputImageTypePointer img,
                                InputPixelType &      max)
 {
   ImageRegionIterator it(img, region);
-  it.GoToBegin();
   min = it.Value();
   max = it.Value();
   while (!it.IsAtEnd())
@@ -1101,8 +1098,6 @@ Segmenter<TInputImage>::RelabelImage(OutputImageTypePointer    img,
 {
   eqTable->Flatten();
   ImageRegionIterator it(img, region);
-
-  it.GoToBegin();
   while (!it.IsAtEnd())
   {
     const IdentifierType temp = eqTable->Lookup(it.Get());

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,6 @@ MRIBiasEnergyFunction<TImage, TImageMask, TBiasField>::GetValue(const Parameters`
`102`	`102`	`else`
`103`	`103`	`{`
`104`	`104`	`ImageRegionIterator mIter(m_Mask, m_Region);`
`105`		`- mIter.GoToBegin();`
`106`	`105`	`while (!bIter.IsAtEnd())`
`107`	`106`	`{`
`108`	`107`	`if (mIter.Get() > 0.0)`
`@@ -547,7 +546,6 @@ MRIBiasFieldCorrectionFilter<TInputImage, TOutputImage, TMaskImage>::CorrectImag`
`547`	`546`	`{`
`548`	`547`	`itkDebugMacro("Output mask is being used");`
`549`	`548`	`ImageRegionIterator mIter(m_OutputMask, region);`
`550`		`- mIter.GoToBegin();`
`551`	`549`	`while (!bIter.IsAtEnd())`
`552`	`550`	`{`
`553`	`551`	`const double inputPixel = iIter.Get();`
Original file line number	Diff line number	Diff line change
`@@ -136,8 +136,7 @@ DiscreteGaussianDerivativeImageFunction<TInputImage, TOutput>::RecomputeGaussian`
`136`	`136`
`137`	`137`	`// Copy kernel image to neighborhood. Do not copy boundaries.`
`138`	`138`	`ImageRegionConstIterator it(kernelImage, kernelRegion);`
`139`		`- it.GoToBegin();`
`140`		`- unsigned int idx = 0;`
	`139`	`+ unsigned int idx = 0;`
`141`	`140`
`142`	`141`	`while (!it.IsAtEnd())`
`143`	`142`	`{`
Original file line number	Diff line number	Diff line change
`@@ -158,8 +158,7 @@ DiscreteGradientMagnitudeGaussianImageFunction<TInputImage, TOutput>::RecomputeG`
`158`	`158`
`159`	`159`	`// Copy kernel image to neighborhood. Do not copy boundaries.`
`160`	`160`	`ImageRegionConstIterator it(kernelImage, kernelRegion);`
`161`		`- it.GoToBegin();`
`162`		`- unsigned int idx = 0;`
	`161`	`+ unsigned int idx = 0;`
`163`	`162`
`164`	`163`	`while (!it.IsAtEnd())`
`165`	`164`	`{`
Original file line number	Diff line number	Diff line change
`@@ -164,8 +164,7 @@ DiscreteHessianGaussianImageFunction<TInputImage, TOutput>::RecomputeGaussianKer`
`164`	`164`
`165`	`165`	`// Copy kernel image to neighborhood. Do not copy boundaries.`
`166`	`166`	`ImageRegionConstIterator it(kernelImage, kernelRegion);`
`167`		`- it.GoToBegin();`
`168`		`- unsigned int idx = 0;`
	`167`	`+ unsigned int idx = 0;`
`169`	`168`	`while (!it.IsAtEnd())`
`170`	`169`	`{`
`171`	`170`	`m_KernelArray[kernelidx][idx] = it.Get();`
Original file line number	Diff line number	Diff line change
`@@ -437,8 +437,6 @@ HistogramMatchingImageFilter<TInputImage, TOutputImage, THistogramMeasurement>::`
`437`	`437`	`{`
`438`	`438`	`// put each image pixel into the histogram`
`439`	`439`	`ImageRegionConstIterator iter(image, image->GetBufferedRegion());`
`440`		`-`
`441`		`- iter.GoToBegin();`
`442`	`440`	`while (!iter.IsAtEnd())`
`443`	`441`	`{`
`444`	`442`	`const InputPixelType & value = iter.Value();`
Original file line number	Diff line number	Diff line change
`@@ -181,8 +181,7 @@ AccumulateImageFilter<TInputImage, TOutputImage>::GenerateData()`
`181`	`181`	`}`
`182`	`182`	`const typename TInputImage::RegionType AccumulatedRegion(AccumulatedIndex, AccumulatedSize);`
`183`	`183`	`ImageRegionConstIterator inputIter(inputImage, AccumulatedRegion);`
`184`		`- inputIter.GoToBegin();`
`185`		`- AccumulateType Value{};`
	`184`	`+ AccumulateType Value{};`
`186`	`185`	`while (!inputIter.IsAtEnd())`
`187`	`186`	`{`
`188`	`187`	`Value += static_cast<AccumulateType>(inputIter.Get());`
Original file line number	Diff line number	Diff line change
`@@ -166,8 +166,6 @@ ImagePCAShapeModelEstimator<TInputImage, TOutputImage>::GenerateData()`
`166`	`166`	`{`
`167`	`167`	`region = this->GetOutput(j)->GetRequestedRegion();`
`168`	`168`	`ImageRegionIterator outIterJ(this->GetOutput(j), region);`
`169`		`-`
`170`		`- outIterJ.GoToBegin();`
`171`	`169`	`while (!outIterJ.IsAtEnd())`
`172`	`170`	`{`
`173`	`171`	`outIterJ.Set(0);`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,6 @@ LabelMapToBinaryImageFilter<TInputImage, TOutputImage>::DynamicThreadedGenerateD`
`123`	`123`	`{`
`124`	`124`	`// fill the background with the background value`
`125`	`125`	`ImageRegionIterator oIt(output, outputRegionForThread);`
`126`		`- oIt.GoToBegin();`
`127`	`126`
`128`	`127`	`while (!oIt.IsAtEnd())`
`129`	`128`	`{`
Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,6 @@ BinomialBlurImageFilter<TInputImage, TOutputImage>::GenerateData()`
`184`	`184`	`//----------------------Reverse pass----------------------`
`185`	`185`	`ImageRegionReverseIterator tempReverseIt(tempPtr, tempPtr->GetRequestedRegion());`
`186`	`186`
`187`		`- tempReverseIt.GoToBegin();`
`188`		`-`
`189`	`187`	`while (!tempReverseIt.IsAtEnd())`
`190`	`188`	`{`
`191`	`189`	`// determine the index of the output pixel`