STYLE: Remove GoToBegin() from Image Iterators in hxx files (manually)

N-Dekker · N-Dekker · commit b3a3e4b41af5 · 2026-03-31T11:14:28.000+02:00
Cases found by the following regular expression: ^([ ]+)(Image\w+Iterator[ ]+)(\w+)(\(.*\);).*?^\1\3\.GoToBegin Manually removed. Follow-up to pull request InsightSoftwareConsortium#4830 commit cf57876 "STYLE: Remove unnecessary iterator `GoToBegin()` calls from Core"
diff --git a/Modules/Filtering/BiasCorrection/include/itkMRIBiasFieldCorrectionFilter.hxx b/Modules/Filtering/BiasCorrection/include/itkMRIBiasFieldCorrectionFilter.hxx
@@ -85,7 +85,6 @@ MRIBiasEnergyFunction<TImage, TImageMask, TBiasField>::GetValue(const Parameters
     typename TBiasField::SimpleForwardIterator bIter(m_BiasField);
 
     bIter.Begin();
-    iIter.GoToBegin();
     total = 0.0;
 
     // Fastest for full sampling
diff --git a/Modules/Filtering/DistanceMap/include/itkSignedMaurerDistanceMapImageFilter.hxx b/Modules/Filtering/DistanceMap/include/itkSignedMaurerDistanceMapImageFilter.hxx
@@ -253,9 +253,6 @@ SignedMaurerDistanceMapImageFilter<TInputImage, TOutputImage>::ThreadedGenerateD
     ImageRegionIterator      Ot(outputPtr, outputRegion);
     ImageRegionConstIterator It(m_InputCache, outputRegion);
 
-    Ot.GoToBegin();
-    It.GoToBegin();
-
     ProgressReporter progress2(this,
                                threadId,
                                outputRegionForThread.GetNumberOfPixels(),
diff --git a/Modules/Filtering/ImageGrid/include/itkBSplineScatteredDataPointSetToImageFilter.hxx b/Modules/Filtering/ImageGrid/include/itkBSplineScatteredDataPointSetToImageFilter.hxx
@@ -658,8 +658,6 @@ BSplineScatteredDataPointSetToImageFilter<TInputPointSet, TOutputImage>::AfterTh
 
       ItD.GoToBegin();
       ItO.GoToBegin();
-      Itd.GoToBegin();
-      Ito.GoToBegin();
       while (!ItD.IsAtEnd())
       {
         ItD.Set(ItD.Get() + Itd.Get());
diff --git a/Modules/Filtering/ImageStatistics/include/itkImagePCAShapeModelEstimator.hxx b/Modules/Filtering/ImageStatistics/include/itkImagePCAShapeModelEstimator.hxx
@@ -149,7 +149,6 @@ ImagePCAShapeModelEstimator<TInputImage, TOutputImage>::GenerateData()
     ImageRegionIterator outIterJ(this->GetOutput(j), region);
 
     unsigned int idx = 0;
-    outIterJ.GoToBegin();
     while (!outIterJ.IsAtEnd())
     {
       outIterJ.Set(static_cast<typename OutputImageType::PixelType>(m_OneEigenVector[idx]));
diff --git a/Modules/Filtering/LabelMap/include/itkLabelMapToBinaryImageFilter.hxx b/Modules/Filtering/LabelMap/include/itkLabelMapToBinaryImageFilter.hxx
@@ -101,9 +101,6 @@ LabelMapToBinaryImageFilter<TInputImage, TOutputImage>::DynamicThreadedGenerateD
     ImageRegionConstIterator bgIt(this->GetBackgroundImage(), outputRegionForThread);
     ImageRegionIterator      oIt(output, outputRegionForThread);
 
-    bgIt.GoToBegin();
-    oIt.GoToBegin();
-
     while (!oIt.IsAtEnd())
     {
       const OutputImagePixelType & bg = bgIt.Get();
diff --git a/Modules/Nonunit/Review/include/itkMultiphaseDenseFiniteDifferenceImageFilter.hxx b/Modules/Nonunit/Review/include/itkMultiphaseDenseFiniteDifferenceImageFilter.hxx
@@ -64,9 +64,6 @@ MultiphaseDenseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputIm
     // Fill the output pointer
     auto p = static_cast<OutputPixelType>(this->m_Lookup[i]);
 
-    in.GoToBegin();
-    out.GoToBegin();
-
     while (!out.IsAtEnd())
     {
       if (in.Get() < 0)
@@ -132,7 +129,6 @@ typename MultiphaseDenseFiniteDifferenceImageFilter<TInputImage, TFeatureImage,
       ImageRegionIterator      nU(m_UpdateBuffers[i], *fIt);
 
       nD.GoToBegin();
-      nU.GoToBegin();
 
       while (!nD.IsAtEnd())
       {
@@ -206,9 +202,6 @@ MultiphaseDenseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputIm
     ImageRegionIterator u(m_UpdateBuffers[i], region);
     ImageRegionIterator o(this->m_LevelSet[i], region);
 
-    u.GoToBegin();
-    o.GoToBegin();
-
     while (!u.IsAtEnd())
     {
       InputPixelType val = static_cast<InputPixelType>(dt) * u.Get();
@@ -240,7 +233,6 @@ MultiphaseDenseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputIm
       rms_change_accumulator = 0;
 
       o.GoToBegin();
-      it.GoToBegin();
 
       while (!o.IsAtEnd())
       {
diff --git a/Modules/Nonunit/Review/include/itkMultiphaseSparseFiniteDifferenceImageFilter.hxx b/Modules/Nonunit/Review/include/itkMultiphaseSparseFiniteDifferenceImageFilter.hxx
@@ -138,9 +138,6 @@ MultiphaseSparseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputI
     ImageRegionIterator lIt(input, region);
     ImageRegionIterator tIt(tempImage, region);
 
-    lIt.GoToBegin();
-    tIt.GoToBegin();
-
     while (!lIt.IsAtEnd())
     {
       tIt.Set(lIt.Get());
@@ -160,7 +157,6 @@ MultiphaseSparseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputI
     ImageRegionIterator zIt(zeroCrossingFilter->GetOutput(), region);
 
     lIt.GoToBegin();
-    zIt.GoToBegin();
 
     while (!lIt.IsAtEnd())
     {
@@ -1121,7 +1117,6 @@ MultiphaseSparseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputI
     ImageRegionConstIterator statusIt(sparsePtr->m_StatusImage, this->m_LevelSet[fId]->GetRequestedRegion());
 
     ImageRegionIterator outputIt(this->m_LevelSet[fId], this->m_LevelSet[fId]->GetRequestedRegion());
-    statusIt.GoToBegin();
 
     while (!outputIt.IsAtEnd())
     {
@@ -1329,9 +1324,6 @@ MultiphaseSparseFiniteDifferenceImageFilter<TInputImage, TFeatureImage, TOutputI
 
     auto p = static_cast<OutputPixelType>(this->m_Lookup[fId]);
 
-    inIt.GoToBegin();
-    outIt.GoToBegin();
-
     while (!outIt.IsAtEnd())
     {
       if (inIt.Get() < 0)
diff --git a/Modules/Numerics/Statistics/include/itkImageClassifierFilter.hxx b/Modules/Numerics/Statistics/include/itkImageClassifierFilter.hxx
@@ -149,9 +149,6 @@ ImageClassifierFilter<TSample, TInputImage, TOutputImage>::GenerateData()
   ImageRegionConstIterator inpItr(inputImage, inputImage->GetBufferedRegion());
   ImageRegionIterator      outItr(outputImage, outputImage->GetBufferedRegion());
 
-  inpItr.GoToBegin();
-  outItr.GoToBegin();
-
   while (!inpItr.IsAtEnd())
   {
     MeasurementVectorType measurements;
diff --git a/Modules/Numerics/Statistics/include/itkMaskedImageToHistogramFilter.hxx b/Modules/Numerics/Statistics/include/itkMaskedImageToHistogramFilter.hxx
@@ -41,10 +41,8 @@ MaskedImageToHistogramFilter<TImage, TMaskImage>::ThreadedComputeMinimumAndMaxim
 
   const MaskPixelType maskValue = this->GetMaskValue();
 
-  ImageRegionConstIterator inputIt(this->GetInput(), inputRegionForThread);
-  ImageRegionConstIterator maskIt(this->GetMaskImage(), inputRegionForThread);
-  inputIt.GoToBegin();
-  maskIt.GoToBegin();
+  ImageRegionConstIterator       inputIt(this->GetInput(), inputRegionForThread);
+  ImageRegionConstIterator       maskIt(this->GetMaskImage(), inputRegionForThread);
   HistogramMeasurementVectorType m(nbOfComponents);
 
   min.Fill(NumericTraits<ValueType>::max());
@@ -84,10 +82,8 @@ MaskedImageToHistogramFilter<TImage, TMaskImage>::ThreadedStreamedGenerateData(c
   histogram->SetMeasurementVectorSize(nbOfComponents);
   histogram->Initialize(outputHistogram->GetSize(), this->m_Minimum, this->m_Maximum);
 
-  ImageRegionConstIterator inputIt(this->GetInput(), inputRegionForThread);
-  ImageRegionConstIterator maskIt(this->GetMaskImage(), inputRegionForThread);
-  inputIt.GoToBegin();
-  maskIt.GoToBegin();
+  ImageRegionConstIterator       inputIt(this->GetInput(), inputRegionForThread);
+  ImageRegionConstIterator       maskIt(this->GetMaskImage(), inputRegionForThread);
   HistogramMeasurementVectorType m(nbOfComponents);
   const MaskPixelType            maskValue = this->GetMaskValue();
 
diff --git a/Modules/Segmentation/Classifiers/include/itkBayesianClassifierInitializationImageFilter.hxx b/Modules/Segmentation/Classifiers/include/itkBayesianClassifierInitializationImageFilter.hxx
@@ -137,9 +137,6 @@ BayesianClassifierInitializationImageFilter<TInputImage, TProbabilityPrecisionTy
   const typename InputImageType::RegionType imageRegion = inputImage->GetLargestPossibleRegion();
   InputImageIteratorType                    itrInputImage(inputImage, imageRegion);
 
-  itrInputImage.GoToBegin();
-  itrKMeansImage.GoToBegin();
-
   // find sumsOfSquares, sums, and classCount by indexing using the kmeans
   // output labelmap
   while (!itrInputImage.IsAtEnd())
diff --git a/Modules/Segmentation/ConnectedComponents/include/itkConnectedComponentFunctorImageFilter.hxx b/Modules/Segmentation/ConnectedComponents/include/itkConnectedComponentFunctorImageFilter.hxx
@@ -118,7 +118,6 @@ ConnectedComponentFunctorImageFilter<TInputImage, TOutputImage, TFunctor, TMaskI
   // current pixel
   init.GoToBegin();
   onit.GoToBegin();
-  it.GoToBegin();
   oit.GoToBegin();
   OutputPixelType maxLabel{};
   // create an equivalency table
diff --git a/Modules/Segmentation/ConnectedComponents/include/itkHardConnectedComponentImageFilter.hxx b/Modules/Segmentation/ConnectedComponents/include/itkHardConnectedComponentImageFilter.hxx
@@ -49,8 +49,6 @@ HardConnectedComponentImageFilter<TInputImage, TOutputImage>::GenerateData()
   ImageRegionIteratorWithIndex ot(output, output->GetRequestedRegion());
 
   ProgressReporter progress(this, 0, output->GetRequestedRegion().GetNumberOfPixels());
-  it.GoToBegin();
-  ot.GoToBegin();
   for (; !it.IsAtEnd(); ++it, ++ot)
   {
     if (Math::NotExactlyEquals(it.Get(), typename ImageRegionConstIterator<TInputImage>::PixelType{}))
diff --git a/Modules/Segmentation/Watersheds/include/itkIsolatedWatershedImageFilter.hxx b/Modules/Segmentation/Watersheds/include/itkIsolatedWatershedImageFilter.hxx
@@ -151,8 +151,6 @@ IsolatedWatershedImageFilter<TInputImage, TOutputImage>::GenerateData()
   const IdentifierType seed1Label = m_Watershed->GetOutput()->GetPixel(m_Seed1);
   const IdentifierType seed2Label = m_Watershed->GetOutput()->GetPixel(m_Seed2);
 
-  it.GoToBegin();
-  ot.GoToBegin();
   while (!it.IsAtEnd())
   {
     IdentifierType value = it.Get();
diff --git a/Modules/Segmentation/Watersheds/include/itkWatershedEquivalenceRelabeler.hxx b/Modules/Segmentation/Watersheds/include/itkWatershedEquivalenceRelabeler.hxx
@@ -39,8 +39,6 @@ EquivalenceRelabeler<TScalar, TImageDimension>::GenerateData()
   ImageRegionConstIterator it_a(input, output->GetRequestedRegion());
   ImageRegionIterator      it_b(output, output->GetRequestedRegion());
 
-  it_a.GoToBegin();
-  it_b.GoToBegin();
   while (!it_a.IsAtEnd())
   {
     it_b.Set(it_a.Get());
diff --git a/Modules/Segmentation/Watersheds/include/itkWatershedRelabeler.hxx b/Modules/Segmentation/Watersheds/include/itkWatershedRelabeler.hxx
@@ -56,8 +56,6 @@ Relabeler<TScalar, TImageDimension>::GenerateData()
   //
   ImageRegionIterator it_a(input, output->GetRequestedRegion());
   ImageRegionIterator it_b(output, output->GetRequestedRegion());
-  it_a.GoToBegin();
-  it_b.GoToBegin();
   while (!it_a.IsAtEnd())
   {
     it_b.Set(it_a.Get());
diff --git a/Modules/Segmentation/Watersheds/include/itkWatershedSegmenter.hxx b/Modules/Segmentation/Watersheds/include/itkWatershedSegmenter.hxx
@@ -1120,9 +1120,6 @@ Segmenter<TInputImage>::Threshold(InputImageTypePointer destination,
   ImageRegionIterator dIt(destination, destination_region);
   ImageRegionIterator sIt(source, source_region);
 
-  dIt.GoToBegin();
-  sIt.GoToBegin();
-
   // Assumes that source_region and destination region are the same size.  Does
   // no checking!!
   if (NumericTraits<InputPixelType>::is_integer)

Original file line number	Diff line number	Diff line change
`@@ -658,8 +658,6 @@ BSplineScatteredDataPointSetToImageFilter<TInputPointSet, TOutputImage>::AfterTh`
`658`	`658`
`659`	`659`	`ItD.GoToBegin();`
`660`	`660`	`ItO.GoToBegin();`
`661`		`- Itd.GoToBegin();`
`662`		`- Ito.GoToBegin();`
`663`	`661`	`while (!ItD.IsAtEnd())`
`664`	`662`	`{`
`665`	`663`	`ItD.Set(ItD.Get() + Itd.Get());`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,6 @@ ImagePCAShapeModelEstimator<TInputImage, TOutputImage>::GenerateData()`
`149`	`149`	`ImageRegionIterator outIterJ(this->GetOutput(j), region);`
`150`	`150`
`151`	`151`	`unsigned int idx = 0;`
`152`		`- outIterJ.GoToBegin();`
`153`	`152`	`while (!outIterJ.IsAtEnd())`
`154`	`153`	`{`
`155`	`154`	`outIterJ.Set(static_cast<typename OutputImageType::PixelType>(m_OneEigenVector[idx]));`
Original file line number	Diff line number	Diff line change
`@@ -101,9 +101,6 @@ LabelMapToBinaryImageFilter<TInputImage, TOutputImage>::DynamicThreadedGenerateD`
`101`	`101`	`ImageRegionConstIterator bgIt(this->GetBackgroundImage(), outputRegionForThread);`
`102`	`102`	`ImageRegionIterator oIt(output, outputRegionForThread);`
`103`	`103`
`104`		`- bgIt.GoToBegin();`
`105`		`- oIt.GoToBegin();`
`106`		`-`
`107`	`104`	`while (!oIt.IsAtEnd())`
`108`	`105`	`{`
`109`	`106`	`const OutputImagePixelType & bg = bgIt.Get();`
Original file line number	Diff line number	Diff line change
`@@ -149,9 +149,6 @@ ImageClassifierFilter<TSample, TInputImage, TOutputImage>::GenerateData()`
`149`	`149`	`ImageRegionConstIterator inpItr(inputImage, inputImage->GetBufferedRegion());`
`150`	`150`	`ImageRegionIterator outItr(outputImage, outputImage->GetBufferedRegion());`
`151`	`151`
`152`		`- inpItr.GoToBegin();`
`153`		`- outItr.GoToBegin();`
`154`		`-`
`155`	`152`	`while (!inpItr.IsAtEnd())`
`156`	`153`	`{`
`157`	`154`	`MeasurementVectorType measurements;`