Merge pull request InsightSoftwareConsortium#6010 from hjmjohnson/style-sizetype-filled

STYLE: Replace declare-then-Fill(N) with ::Filled(N) factory method

Author: hjmjohnson

Modules/Core/Common/test/itkBSplineInterpolationWeightFunctionTest.cxx

@@ -254,11 +254,10 @@ itkBSplineInterpolationWeightFunctionTest(int, char *[])
 
     std::cout << "Number Of Weights: " << numberOfWeights << std::endl;
 
-    ContinuousIndexType position;
-    WeightsType         weights;
-    IndexType           startIndex;
+    auto        position = itk::MakeFilled<ContinuousIndexType>(4.15);
+    WeightsType weights;
+    IndexType   startIndex;
 
-    position.Fill(4.15);
     weights = function->Evaluate(position);
 
     std::cout << "Position: " << position << std::endl;

Modules/Core/Common/test/itkImageVectorOptimizerParametersHelperTest.cxx

@@ -78,9 +78,8 @@ testMemoryAccess(OptimizerParametersType & params, ImageVectorPointer imageOfVec
 int
 itkImageVectorOptimizerParametersHelperTest(int, char *[])
 {
-  SizeType      size;
   constexpr int dimLength{ 3 };
-  size.Fill(dimLength);
+  auto          size = itk::MakeFilled<SizeType>(dimLength);
 
   const RegionType region{ size };
 

Modules/Core/ImageFunction/include/itkGaussianInterpolateImageFunction.hxx

@@ -109,13 +109,10 @@ GaussianInterpolateImageFunction<TImageType, TCoordinate>::EvaluateAtContinuousI
 
   RealType  sum_me = 0.0;
   RealType  sum_m = 0.0;
-  ArrayType dsum_me;
-  ArrayType dsum_m;
-  ArrayType dw;
+  ArrayType dsum_me{};
+  ArrayType dsum_m{};
+  ArrayType dw{};
 
-  dsum_m.Fill(0.0);
-  dsum_me.Fill(0.0);
-  dw.Fill(0.0);
 
   for (ImageRegionConstIteratorWithIndex It(this->GetInputImage(), region); !It.IsAtEnd(); ++It)
   {

Modules/Core/ImageFunction/test/itkCentralDifferenceImageFunctionTest.cxx

@@ -63,10 +63,9 @@ itkCentralDifferenceImageFunctionTest(int, char *[])
 
   function->SetInputImage(image);
 
-  ImageType::IndexType index;
+  auto index = itk::MakeFilled<ImageType::IndexType>(8);
 
   // pick an index inside the image
-  index.Fill(8);
   OutputType indexOutput = function->EvaluateAtIndex(index);
   std::cout << "Index: " << index << " Derivative: ";
   std::cout << indexOutput << std::endl;

Modules/Core/ImageFunction/test/itkGaussianInterpolateImageFunctionTest.cxx

@@ -49,11 +49,9 @@ itkGaussianInterpolateImageFunctionTest(int, char *[])
   image->SetRegions(region);
   image->Allocate();
 
-  ImageType::PointType   origin;
-  ImageType::SpacingType spacing;
+  ImageType::PointType origin{};
+  auto                 spacing = itk::MakeFilled<ImageType::SpacingType>(1.0);
 
-  origin.Fill(0.0);
-  spacing.Fill(1.0);
 
   image->SetOrigin(origin);
   image->SetSpacing(spacing);

Modules/Core/ImageFunction/test/itkLinearInterpolateImageFunctionTest.cxx

@@ -59,9 +59,8 @@ RunLinearInterpolateTest()
   auto variablevectorimage = VariableVectorImageType::New();
   variablevectorimage->SetVectorLength(VectorDimension);
 
-  SizeType      size;
   constexpr int dimMaxLength{ 3 };
-  size.Fill(dimMaxLength);
+  auto          size = itk::MakeFilled<SizeType>(dimMaxLength);
 
   const RegionType region{ size };
 

Modules/Core/ImageFunction/test/itkNearestNeighborInterpolateImageFunctionTest.cxx

@@ -71,11 +71,9 @@ itkNearestNeighborInterpolateImageFunctionTest(int, char *[])
   variablevectorimage->SetRegions(region);
   variablevectorimage->Allocate();
 
-  ImageType::PointType   origin;
-  ImageType::SpacingType spacing;
+  ImageType::PointType origin{};
+  auto                 spacing = itk::MakeFilled<ImageType::SpacingType>(1.0);
 
-  origin.Fill(0.0);
-  spacing.Fill(1.0);
 
   image->SetOrigin(origin);
   image->SetSpacing(spacing);

Modules/Core/SpatialObjects/include/itkContourSpatialObject.hxx

@@ -73,10 +73,8 @@ ContourSpatialObject<TDimension>::GetOrientationInObjectSpace() const
   const ContourPointListType & points = this->GetPoints();
   auto                         it = points.begin();
   auto                         itend = points.end();
-  PointType                    minPnt;
-  PointType                    maxPnt;
-  minPnt.Fill(NumericTraits<double>::max());
-  maxPnt.Fill(NumericTraits<double>::NonpositiveMin());
+  auto                         minPnt = MakeFilled<PointType>(NumericTraits<double>::max());
+  auto                         maxPnt = MakeFilled<PointType>(NumericTraits<double>::NonpositiveMin());
   while (it != itend)
   {
     PointType curpoint = it->GetPositionInObjectSpace();

Modules/Core/SpatialObjects/include/itkPolygonSpatialObject.hxx

@@ -61,10 +61,8 @@ PolygonSpatialObject<TDimension>::GetOrientationInObjectSpace() const
   const PolygonPointListType & points = this->GetPoints();
   auto                         it = points.begin();
   auto                         itend = points.end();
-  PointType                    minPnt;
-  PointType                    maxPnt;
-  minPnt.Fill(NumericTraits<double>::max());
-  maxPnt.Fill(NumericTraits<double>::NonpositiveMin());
+  auto                         minPnt = MakeFilled<PointType>(NumericTraits<double>::max());
+  auto                         maxPnt = MakeFilled<PointType>(NumericTraits<double>::NonpositiveMin());
   while (it != itend)
   {
     PointType curpoint = it->GetPositionInObjectSpace();

Modules/Core/Transform/include/itkKernelTransform.hxx

@@ -318,11 +318,10 @@ auto
 KernelTransform<TParametersValueType, VDimension>::TransformPoint(const InputPointType & thisPoint) const
   -> OutputPointType
 {
-  OutputPointType result;
-
   using ValueType = typename OutputPointType::ValueType;
 
-  result.Fill(ValueType{});
+  auto result = MakeFilled<OutputPointType>(ValueType{});
+
 
   // TODO:  It is unclear if the following line is needed.
   this->ComputeDeformationContribution(thisPoint, result);