Skip to content

Commit f87d036

Browse files
authored
Merge pull request InsightSoftwareConsortium#5985 from hjmjohnson/convert-WindowConvergenceMonitoringFunction-to-gtest
ENH: Convert itkWindowConvergenceMonitoringFunctionTest to GTest
2 parents 14d5eb0 + adabc58 commit f87d036

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

Modules/Numerics/Optimizersv4/test/CMakeLists.txt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ set(
1717
itkRegistrationParameterScalesFromJacobianTest.cxx
1818
itkAutoScaledGradientDescentRegistrationTest.cxx
1919
itkAutoScaledGradientDescentRegistrationOnVectorTest.cxx
20-
itkWindowConvergenceMonitoringFunctionTest.cxx
2120
itkQuasiNewtonOptimizerv4Test.cxx
2221
itkObjectToObjectMetricBaseTest.cxx
2322
itkLBFGSOptimizerv4Test.cxx
@@ -36,12 +35,8 @@ set(TEMP ${ITK_TEST_OUTPUT_DIR})
3635

3736
createtestdriver(ITKOptimizersv4 "${ITKOptimizersv4-Test_LIBRARIES}" "${ITKOptimizersv4Tests}")
3837

39-
itk_add_test(
40-
NAME itkWindowConvergenceMonitoringFunctionTest
41-
COMMAND
42-
ITKOptimizersv4TestDriver
43-
itkWindowConvergenceMonitoringFunctionTest
44-
)
38+
set(ITKOptimizersv4GTests itkWindowConvergenceMonitoringFunctionGTest.cxx)
39+
creategoogletestdriver(ITKOptimizersv4 "${ITKOptimizersv4-Test_LIBRARIES}" "${ITKOptimizersv4GTests}")
4540

4641
itk_add_test(
4742
NAME itkObjectToObjectOptimizerBaseTest

Modules/Numerics/Optimizersv4/test/itkWindowConvergenceMonitoringFunctionTest.cxx renamed to Modules/Numerics/Optimizersv4/test/itkWindowConvergenceMonitoringFunctionGTest.cxx

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
*=========================================================================*/
1818

1919
#include "itkWindowConvergenceMonitoringFunction.h"
20+
#include "itkGTest.h"
2021

21-
int
22-
itkWindowConvergenceMonitoringFunctionTest(int itkNotUsed(argc), char *[])
22+
TEST(WindowConvergenceMonitoringFunction, ConvertedLegacyTest)
2323
{
2424
using RealType = float;
2525

@@ -31,19 +31,11 @@ itkWindowConvergenceMonitoringFunctionTest(int itkNotUsed(argc), char *[])
3131
for (RealType x = 0.0; x < 20; x += 1.0)
3232
{
3333
convergenceMonitoring->AddEnergyValue(std::pow(static_cast<RealType>(2.0), -x));
34-
try
35-
{
36-
std::cout << "convergence value: " << convergenceMonitoring->GetConvergenceValue() << std::endl;
37-
}
38-
catch (...)
39-
{
40-
std::cout << "GetConvergenceValue() failed." << std::endl;
41-
return EXIT_FAILURE;
42-
}
34+
RealType convergenceValue{};
35+
EXPECT_NO_THROW(convergenceValue = convergenceMonitoring->GetConvergenceValue());
36+
std::cout << "convergence value: " << convergenceValue << std::endl;
4337
}
4438

4539
convergenceMonitoring->GetWindowSize();
4640
convergenceMonitoring->Print(std::cout, 3);
47-
48-
return EXIT_SUCCESS;
4941
}

0 commit comments

Comments
 (0)