Refactoring: reduce code duplication in expert.cpp

Author: doxygen

addon/doxywizard/expert.cpp

@@ -65,6 +65,17 @@ static QString convertToComment(const QString &s)
   }
 }
 
+static QString displayDocs(const QString &id,const QString &docs)
+{
+  QString display = SMALL_FONT_START + SA("<b>") + id + SA("</b>");
+  if (!docs.isEmpty())
+  {
+    display += SA(" &mdash; ") + docs;
+  }
+  display += SMALL_FONT_END;
+  return display;
+}
+
 void Expert::setHeader(const char *header)
 {
   m_header = SA(header);
@@ -515,14 +526,7 @@ void Expert::createOptionCard(GroupEntry &group, const QDomElement &child)
     docsLabel->setWordWrap(true);
     docsLabel->setOpenExternalLinks(true);
     docsLabel->setContentsMargins(0, 2, 0, 4);
-    // Use a smaller, muted style for the description text
-    QString display = SMALL_FONT_START + SA("<b>") + id + SA("</b>");
-    if (!docs.isEmpty())
-    {
-      display += SA(" &mdash; ") + docs;
-    }
-    display += SMALL_FONT_END;
-    docsLabel->setText(display);
+    docsLabel->setText(displayDocs(id,docs));
     // Dim the label using PlaceholderText, which is calibrated for readable
     // secondary text in both light and dark modes (available since Qt 5.12).
     QColor textColor = docsLabel->palette().color(QPalette::Text);
@@ -1143,13 +1147,7 @@ void Expert::filterChanged(const QString &text)
         }
         if (opt.docsLabel && opt.labelHighlighted)
         {
-          QString display = SMALL_FONT_START + SA("<b>") + opt.id + SA("</b>");
-          if (!opt.docs.isEmpty())
-          {
-            display += SA(" &mdash; ") + opt.docs;
-          }
-          display += SMALL_FONT_END;
-          opt.docsLabel->setText(display);
+          opt.docsLabel->setText(displayDocs(opt.id, opt.docs));
           opt.input->setText(opt.id);
           opt.labelHighlighted = false;
         }
@@ -1190,13 +1188,7 @@ void Expert::filterChanged(const QString &text)
           QString hiDocs = matchesDocs ? highlightInHtml(opt.docs, filter) : opt.docs;
           QString hiId   = matchesId   ? highlightInHtml(opt.id,   filter) : opt.id;
           opt.input->setText(hiId);
-          QString display = SMALL_FONT_START + SA("<b>") + hiId + SA("</b>");
-          if (!opt.docs.isEmpty())
-          {
-            display += SA(" &mdash; ") + hiDocs;
-          }
-          display += SMALL_FONT_END;
-          opt.docsLabel->setText(display);
+          opt.docsLabel->setText(displayDocs(hiId,hiDocs));
           opt.labelHighlighted = true;
         }