This repository was archived by the owner on Mar 11, 2026. It is now read-only.
fix: handle orphan subscription messages during WebSocket reconnection#549
Open
demora33 wants to merge 2 commits into
Open
fix: handle orphan subscription messages during WebSocket reconnection#549demora33 wants to merge 2 commits into
demora33 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547
Problem
During WebSocket reconnection, handleMessage() can crash due to timing-related race conditions when in-flight messages arrive before subscriptions are fully restored.
Crash 1: Malformed messages (line 500)
Some messages pass isSubscriptionEvent() but do not contain a params object.
Since isSubscriptionEvent() only checks that the message is not a response (id is undefined), accessing message.params.subscription can throw.
Crash 2: Orphan subscription messages (line ~505)
TypeError: Cannot read properties of undefined (reading 'method')This occurs when a virtualId still exists in virtualIdsByPhysicalId but the corresponding entry has already been removed from virtualSubscriptionsById
The existing non-null assertion (!) causes a crash when accessing subscription.method.
Both issues are race conditions that happen during the reconnection window while SturdyWebSocket is re-establishing the connection and re-subscribing.
Root Cause Analysis Timeline: