Added mem-dbg as optional feature#19
Open
LucaCappelletti94 wants to merge 7 commits intoalecmocatta:masterfrom
Open
Added mem-dbg as optional feature#19LucaCappelletti94 wants to merge 7 commits intoalecmocatta:masterfrom
LucaCappelletti94 wants to merge 7 commits intoalecmocatta:masterfrom
Conversation
Author
|
FYI, the errors are caused by the CI configuration being old. Consider updating it. |
Owner
|
Thanks for this! Let me know when done and will merge despite the outdated CI. |
Author
|
Hi @alecmocatta, sure - I am running some benchmarks so I may add some other small edits. |
Author
|
Why are you checking whether the estimates are three-sorted? I see that you run a binary search but that requires the estimates to be completely sorted, and I recently discovered that the estimates provided from the HLL++ paper are not sorted (they nearly are). I will be providing a fix for that shortly. streaming_algorithms/src/distinct/consts.rs Lines 33 to 45 in 99522db |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mem-dbg is a crate that allows to compute the size of a struct. I have added the derives through the crate as an optional feature, so as to use it to compare this implementation with others easily.
Cheers!