Skip to content

Commit 371f1f8

Browse files
fix: scope default build to desktop-only, document build target in AGENTS.md
The unfiltered `turbo run build` was building all 5 workspaces including marketing. Since desktop is the primary target, `bun build` now matches `build:desktop`. AGENTS.md updated so agents know not to include marketing in default builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 80eb944 commit 371f1f8

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

AGENTS.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,16 @@ If a tradeoff is required, choose correctness and robustness over short-term con
2323

2424
Long term maintainability is a core priority. If you add new functionality, first check if there is shared logic that can be extracted to a separate module. Duplicate logic across multiple files is a code smell and should be avoided. Don't be afraid to change existing code. Don't take shortcuts by just adding local logic to solve a problem.
2525

26+
## Build Target
27+
28+
The primary build target is the **desktop app** (`apps/desktop`). `bun build` and `bun dev:desktop` build only what's needed for it. `apps/marketing` is a separate landing site — don't include it in default builds or dev workflows.
29+
2630
## Package Roles
2731

32+
- `apps/desktop`: Electron desktop app. This is the primary distribution target.
2833
- `apps/server`: Node.js WebSocket server. Wraps Codex app-server (JSON-RPC over stdio), serves the React web app, and manages provider sessions.
2934
- `apps/web`: React/Vite UI. Owns session UX, conversation/event rendering, and client-side state. Connects to the server via WebSocket.
35+
- `apps/marketing`: Astro landing/marketing site. Separate from the app — has its own `build:marketing` and `dev:marketing` scripts. Do not include in default builds.
3036
- `packages/contracts`: Shared effect/Schema schemas and TypeScript contracts for provider events, WebSocket protocol, and model/session types. Keep this package schema-only — no runtime logic.
3137
- `packages/shared`: Shared runtime utilities consumed by both server and web. Uses explicit subpath exports (e.g. `@t3tools/shared/git`) — no barrel index.
3238

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"start:desktop": "turbo run start --filter=@t3tools/desktop",
3535
"start:marketing": "turbo run preview --filter=@t3tools/marketing",
3636
"start:mock-update-server": "bun run scripts/mock-update-server.ts",
37-
"build": "turbo run build",
37+
"build": "turbo run build --filter=@t3tools/desktop --filter=t3",
3838
"build:marketing": "turbo run build --filter=@t3tools/marketing",
3939
"build:desktop": "turbo run build --filter=@t3tools/desktop --filter=t3",
4040
"typecheck": "turbo run typecheck",

0 commit comments

Comments
 (0)