Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions benchmarks.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,15 @@ var benchmarkCases = []BenchmarkCase{

TimeSupport: TSNoSupport,
APIKind: AKCodegen,
}, {
Name: "flatbuffers/unsafe_reuse",
URL: "github.com/google/flatbuffers/go",
New: flatbuffers.NewFlatBuffersUnsafeReuseSerializer,

TimeSupport: TSNoSupport,
APIKind: AKCodegen,
UnsafeStringUnmarshal: true,
BufferReuseMarshal: true,
}, {
Name: "capnproto",
URL: "github.com/glycerine/go-capnproto",
Expand Down
32 changes: 26 additions & 6 deletions internal/serializers/flatbuffers/flatbuffers.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,23 @@ package flatbuffers

import (
"time"
"unsafe"

"github.com/alecthomas/go_serialization_benchmarks/goserbench"
flatbuffers "github.com/google/flatbuffers/go"
)

type FlatBufferSerializer struct {
builder *flatbuffers.Builder
unsafeReuse bool
builder *flatbuffers.Builder
}

func (s *FlatBufferSerializer) Marshal(o interface{}) ([]byte, error) {
a := o.(*goserbench.SmallStruct)
builder := s.builder
builder.Bytes = nil // free
if !s.unsafeReuse {
builder.Bytes = nil // free
}
builder.Reset()

name := builder.CreateString(a.Name)
Expand All @@ -28,22 +32,38 @@ func (s *FlatBufferSerializer) Marshal(o interface{}) ([]byte, error) {
FlatBufferAAddSpouse(builder, a.Spouse)
FlatBufferAAddMoney(builder, a.Money)
builder.Finish(FlatBufferAEnd(builder))
return builder.Bytes[builder.Head():], nil
return builder.FinishedBytes(), nil
}

func (s *FlatBufferSerializer) Unmarshal(d []byte, i interface{}) error {
a := i.(*goserbench.SmallStruct)
o := FlatBufferA{}
o.Init(d, flatbuffers.GetUOffsetT(d))
a.Name = string(o.Name())
if s.unsafeReuse {
a.Name = unsafeSliceToString(o.Name())
a.Phone = unsafeSliceToString(o.Phone())
} else {
a.Name = string(o.Name())
a.Phone = string(o.Phone())
}
a.BirthDay = time.Unix(0, o.BirthDay())
a.Phone = string(o.Phone())
a.Siblings = int(o.Siblings())
a.Spouse = o.Spouse()
a.Money = o.Money()
return nil
}

func NewFlatBuffersSerializer() goserbench.Serializer {
return &FlatBufferSerializer{flatbuffers.NewBuilder(0)}
return &FlatBufferSerializer{builder: flatbuffers.NewBuilder(0), unsafeReuse: false}
}

func NewFlatBuffersUnsafeReuseSerializer() goserbench.Serializer {
const maxSerSize = 128
return &FlatBufferSerializer{builder: flatbuffers.NewBuilder(maxSerSize), unsafeReuse: true}
}

// unsafeSliceToString converts a byte slice to a string in an unsafe way
// (modifications to the byte slice modify the string).
func unsafeSliceToString(b []byte) string {
return *(*string)(unsafe.Pointer(&b))
}
Loading
Loading