Skip to content

Fix fetchdir with relative URLs #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdeden merged 1 commit into from
Mar 3, 2026
Merged

Fix fetchdir with relative URLs #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions alephclient/fetchdir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from pathlib import Path
from pprint import pprint # noqa
from typing import Optional, Dict
from urllib.parse import urlparse, urljoin

from alephclient.api import AlephAPI

Expand Down Expand Up @@ -36,6 +37,9 @@ def fetch_object(api: AlephAPI, path: Path, entity: Dict, overwrite: bool = Fals
object_path = path.joinpath(file_name)
url = entity.get("links", {}).get("file")
if url is not None:
# Aleph Pro may return relative URLs (e.g. /api/2/archive?token=...)
if not urlparse(url).scheme:
url = urljoin(api.base_url, url)
# Skip existing files after checking file size:
if not overwrite and object_path.exists():
for file_size in entity.get("properties", {}).get("fileSize", []):
Expand Down