Alternate cfg pattern#63
Open
alephzero wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate
cfgimplementation with much less magic.Previously,
cfgwas an object wrapper that would masquerade as the requested type in almost every way. The two major exceptions was 1)type(obj)would not match the underlying type, and 2) C-bindings were not fooled.The masquerading objects were hooked and updates when the user calls
a0.update_configs()New
cfg2has the same signature, but returns a non-masquerading object that has an explicitget()method.get()returns a true object of the requested type, not one that updates under the hood.get()always returns the most recent version. No need for an update call.Example usage here:
Ideal transition plan:
cfg2cfgtocfg2cfgexists, aliascfg==cfg2cfg2tocfgcfg2We'll see how well that turns out.