This repository was archived by the owner on Feb 21, 2023. It is now read-only.
Open
Conversation
|
I can confirm that this fixed #42 for me by bumping this version up. For people using node 8 (which anyone following the instructions and doing a |
Author
|
@rjamison any chance of getting this merged? It's a very small non-code change that means the project is actually usable in a modern node stack. |
|
I'm not sure this repo is being maintained any more. I'm maintaining an updated version with this fix included at samdobson/interactive-adventure-game-tool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks so much for this project — looking forward to poking at it as an example!
Node v8 introduced some breaking changes that break versions of
require-dirprior to0.3.2. On my local dev machine, which runs Node 8, a clean clone andnpm installof this repo pulled down an older version ofrequest-dirthat crashes on run.This just bumps the package.json to use a version of
require-dirthat has the node 8 fix. The more proper solution would be to introduce a lockfile of some sort (whether ayarnfile.lockorpackage-lock.json), but seeing as this isn't my project I don't want to pick a side on yarn vs npm for you :P.