fix: Harness hook 추론과 runtime surface 검증 강화#96
Merged
Conversation
- completed task scope 기준 pre-push 검증과 fail-closed task 추론 보강 - init과 doctor에 githook 및 hooks.json 동기화와 drift 검출 추가 - dead hook surface 제거와 문서 및 회귀 테스트 정리
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0da1167012
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre-push가 올바른 task/phase context로 latest verification gate를 평가하도록 수정했습니다.init가 runtime surface를 source 기준으로 다시 동기화하고,doctor가.githooks/*와workflows/system/hooks.jsondrift를 실패로 감지하도록 보강했습니다.pre_phase_start와 미사용dangerous_cmd_guard.allowlist를 제거하고 관련 문서, skills, 회귀 테스트를 정리했습니다.Linked Issue
How
pre_push전용 task inference를 수행하도록 순서를 바꿨습니다.pre_push는 active task뿐 아니라completedtask까지 scope 매핑 후보에 포함하고, 단일 task로 해석되지 않으면 fail-closed 하도록 했습니다..githooks/pre-push는 shell 단계에서 active task를 먼저 박아 넣지 않고 CLI inference에 맡기도록 단순화했습니다.init와doctor의 책임을 분리해 source surface copy와 content drift validation을 명시적으로 추가했습니다.Validation Summary
python3 -m unittest discover -s tests -v통과python3 scripts/workflow.py doctor통과python3 scripts/workflow.py status --all --check통과git diff --check통과Reviewer Focus
pre_pushtask inference가 completed task와 active task가 섞인 상황에서도 의도대로 fail-closed 하는지init/doctor분리가 외부 workspace install 흐름과 충돌하지 않는지Impact / Risks
init재실행이 필요할 수 있습니다.