[Task] GRB-04/GRB-07 backend verification과 AGENTS entrypoint 정렬#81
Merged
alexization merged 5 commits intoApr 14, 2026
Merged
Conversation
added 3 commits
April 9, 2026 15:59
- legacy verification Gradle task와 CI workflow 제거 - OpenAPI tracked 문서와 verification 전용 테스트 제거 - harness 재구성을 위한 clean baseline 정리
- backend root AGENTS.md 추가 - README overview-only 원칙과 verification/bootstrap discovery order 명시 - local skill 부재 시 repo-local fallback source 정리
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughCI/CD 파이프라인, 빌드 설정 및 테스트 표면을 정리합니다. JaCoCo 커버리지 확인, OpenAPI 스냅샷 생성, Docker 프리플라이트 확인, 아키텍처 가드레일 테스트를 제거하고, 워크플로우를 단순화하며, AGENTS.md 엔트리포인트를 추가합니다. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20분 Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e10e385d33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/deploy.yml (1)
77-82:⚠️ Potential issue | 🟠 Major수동 실행이 임의 브랜치에서도 프로덕션 배포를 허용합니다.
Line 82의 조건은
workflow_dispatch면 ref와 무관하게deployjob을 실행합니다. 지금 상태면 feature branch에서 수동 실행한 코드도 프로덕션으로 배포될 수 있습니다. 수동 배포도main또는 릴리스 태그로 제한해 주세요.🔒 제안 수정안
- if: github.ref == 'refs/heads/main' || github.event_name == 'workflow_dispatch' + if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v')🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/deploy.yml around lines 77 - 82, 현재 deploy 잡의 실행 조건(if: github.ref == 'refs/heads/main' || github.event_name == 'workflow_dispatch') 때문에 workflow_dispatch로 임의 브랜치에서 수동 실행하면 프로덕션 배포가 가능하므로, deploy job의 조건을 배포 허용 ref로 제한하도록 변경하세요: deploy job의 현재 if 표현식(라인에 있는 "if: github.ref == 'refs/heads/main' || github.event_name == 'workflow_dispatch'")을 대체하여 오직 main 브랜치 또는 릴리스 태그(refs/tags/*)일 때만 실행되도록 만드세요 (예: if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/')), 이렇게 하면 수동 실행(workflow_dispatch)도 main 또는 태그에 한해 프로덕션 배포가 가능해집니다.
🧹 Nitpick comments (1)
.github/workflows/deploy.yml (1)
15-37:verifyjob 정의가 CI와 이중화되어 드리프트 포인트가 하나 더 생깁니다.
.github/workflows/ci.yml의verify와 단계가 사실상 동일합니다. 지금 형태는 검증 lane을 바꿀 때 두 워크플로를 항상 같이 수정해야 해서 쉽게 어긋납니다. reusable workflow나 composite action으로 공통화해 한 곳에서 관리하는 편이 안전합니다.Based on learnings: Keep verification lane and deploy gate configuration synchronized across build.gradle, workflow YAML files, and AGENTS.md documentation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/deploy.yml around lines 15 - 37, The verify job duplicate is causing drift; extract the shared steps (the job named "verify" including steps like granting execute permission for gradlew, running ./gradlew test and ./gradlew integrationTest) into a reusable workflow or composite action, replace the inline verify job in this deploy workflow and the other CI workflow to call that reusable workflow, and update any references (build.gradle verification tasks and AGENTS.md) to point to the centralized verification pipeline so changes are made in one place.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Around line 26-28: The AGENTS.md entry incorrectly lists "./gradlew build" as
part of the verification surface even though integrationTest is not hooked into
the "check" lifecycle (see integrationTest and check in build.gradle), so either
remove "build" from the verification list or replace it with the correct
aggregate task name that actually runs integrationTest; update AGENTS.md
accordingly and ensure the verification lane/deploy gate terminology matches the
actual task wiring in build.gradle and the workflow YAML (search for
integrationTest, check, and the verification lane/deploy gate names to make the
edits).
---
Outside diff comments:
In @.github/workflows/deploy.yml:
- Around line 77-82: 현재 deploy 잡의 실행 조건(if: github.ref == 'refs/heads/main' ||
github.event_name == 'workflow_dispatch') 때문에 workflow_dispatch로 임의 브랜치에서 수동
실행하면 프로덕션 배포가 가능하므로, deploy job의 조건을 배포 허용 ref로 제한하도록 변경하세요: deploy job의 현재 if
표현식(라인에 있는 "if: github.ref == 'refs/heads/main' || github.event_name ==
'workflow_dispatch'")을 대체하여 오직 main 브랜치 또는 릴리스 태그(refs/tags/*)일 때만 실행되도록 만드세요
(예: if: github.ref == 'refs/heads/main' || startsWith(github.ref,
'refs/tags/')), 이렇게 하면 수동 실행(workflow_dispatch)도 main 또는 태그에 한해 프로덕션 배포가 가능해집니다.
---
Nitpick comments:
In @.github/workflows/deploy.yml:
- Around line 15-37: The verify job duplicate is causing drift; extract the
shared steps (the job named "verify" including steps like granting execute
permission for gradlew, running ./gradlew test and ./gradlew integrationTest)
into a reusable workflow or composite action, replace the inline verify job in
this deploy workflow and the other CI workflow to call that reusable workflow,
and update any references (build.gradle verification tasks and AGENTS.md) to
point to the centralized verification pipeline so changes are made in one place.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 14f76819-6136-4ca3-8b06-9a4529dfe96d
📒 Files selected for processing (13)
.github/workflows/ci.yml.github/workflows/deploy.yml.github/workflows/quality-gate.ymlAGENTS.mdREADME.mdbuild.gradledocs/openapi/README.mddocs/openapi/openapi.jsonsrc/test/java/com/gitranker/api/architecture/ArchitectureGuardrailTest.javasrc/test/java/com/gitranker/api/docs/OpenApiDocsTest.javasrc/test/java/com/gitranker/api/testsupport/DockerPreflightCheck.javasrc/test/java/com/gitranker/api/testsupport/DockerPreflightCheckTest.javasrc/test/java/com/gitranker/api/testsupport/DockerPreflightMain.java
💤 Files with no reviewable changes (9)
- README.md
- docs/openapi/README.md
- docs/openapi/openapi.json
- .github/workflows/quality-gate.yml
- src/test/java/com/gitranker/api/testsupport/DockerPreflightCheckTest.java
- src/test/java/com/gitranker/api/docs/OpenApiDocsTest.java
- src/test/java/com/gitranker/api/architecture/ArchitectureGuardrailTest.java
- src/test/java/com/gitranker/api/testsupport/DockerPreflightMain.java
- src/test/java/com/gitranker/api/testsupport/DockerPreflightCheck.java
- CI와 deploy verify 단계에 packaging build 추가 - 수동 배포를 main과 release tag ref로 제한 - AGENTS verification 문구를 실제 task wiring에 맞게 수정
alexization
deleted the
feat/grb-04-grb-07-verification-entrypoint-alignment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1) 요약
AGENTS.mdentrypoint를 추가했습니다.2) 연관 이슈
3) 문제와 목표
4) 영향 범위
build.gradle.github/workflows/ci.yml.github/workflows/deploy.ymlREADME.mdAGENTS.md5) 검증 증거
./gradlew build./gradlew test./gradlew integrationTest미실행(현재 baseline 비포함)미실행(public API behavior 비변경)6) 관측성 확인
7) AI 리뷰 메모 (선택)
./gradlew test,./gradlew buildpass와 prior PR [Task] GRB-04 backend verification contract reset #78 integration CI success를 기준으로 baseline을 재검증했습니다.8) 리스크 및 롤백
9) 체크리스트
Summary by CodeRabbit
릴리스 노트
Chores
Tests
Documentation