Load using-module bytecode before @after_compile checks#13
Open
futhr wants to merge 1 commit intoalexocode:mainfrom
Open
Load using-module bytecode before @after_compile checks#13futhr wants to merge 1 commit intoalexocode:mainfrom
futhr wants to merge 1 commit intoalexocode:mainfrom
Conversation
Elixir 1.19's compiler no longer auto-loads the using module before @after_compile fires, so function_exported?/2 reports false for the freshly compiled struct and Brex.Operator (and any user struct rule) fails to compile with "is not a struct". Force-load the bytecode passed to the callback before running the struct + evaluate/2 checks, and add Elixir 1.19 / OTP 28 to the CI matrix so the regression is caught upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elixir 1.19's compiler no longer auto-loads the using module before @after_compile fires, so function_exported?/2 reports false for the freshly compiled struct and Brex.Operator (and any user struct rule) fails to compile with "is not a struct".
Force-load the bytecode passed to the callback before running the struct + evaluate/2 checks, and add Elixir 1.19 / OTP 28 to the CI matrix so the regression is caught upstream.