Skip to content

feat(actions): add SelectNextHalfPage & SelectPrevHalfPage actions#1027

Open
rudenkornk wants to merge 1 commit into
alexpasmantier:mainfrom
rudenkornk:halves
Open

feat(actions): add SelectNextHalfPage & SelectPrevHalfPage actions#1027
rudenkornk wants to merge 1 commit into
alexpasmantier:mainfrom
rudenkornk:halves

Conversation

@rudenkornk
Copy link
Copy Markdown
Contributor

📺 PR Description

Checklist

  • my commits and PR title follow the conventional commits format
  • if this is a new feature, I have added tests to consolidate the feature and prevent regressions
  • if this is a bug fix, I have added a test that reproduces the bug (if applicable)
  • I have added a reasonable amount of documentation to the code where appropriate

Copilot AI review requested due to automatic review settings April 9, 2026 12:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds two new navigation actions to move selection by half a page, integrating them into the action enum, UI help relevance filtering, and Television’s action handling/render-trigger logic.

Changes:

  • Introduces SelectNextHalfPage / SelectPrevHalfPage in Action with help descriptions.
  • Handles the new actions in Television::handle_action by moving the cursor by half the results panel height (channel mode).
  • Marks the new actions as relevant for help display and as render-triggering actions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
television/television.rs Adds rendering relevance + action handlers for half-page selection movement.
television/screen/help_panel.rs Includes half-page actions in the “relevant actions” set for help display.
television/action.rs Adds new Action variants and user-facing descriptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread television/television.rs
Comment thread television/television.rs
Comment thread television/screen/help_panel.rs
Comment thread television/action.rs
Comment thread television/television.rs
@rudenkornk
Copy link
Copy Markdown
Contributor Author

@alexpasmantier may I ask you to take a look on this PR? :)

@rudenkornk
Copy link
Copy Markdown
Contributor Author

@alexpasmantier ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants