feat(actions): add SelectNextHalfPage & SelectPrevHalfPage actions#1027
Open
rudenkornk wants to merge 1 commit into
Open
feat(actions): add SelectNextHalfPage & SelectPrevHalfPage actions#1027rudenkornk wants to merge 1 commit into
rudenkornk wants to merge 1 commit into
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
Adds two new navigation actions to move selection by half a page, integrating them into the action enum, UI help relevance filtering, and Television’s action handling/render-trigger logic.
Changes:
- Introduces
SelectNextHalfPage/SelectPrevHalfPageinActionwith help descriptions. - Handles the new actions in
Television::handle_actionby moving the cursor by half the results panel height (channel mode). - Marks the new actions as relevant for help display and as render-triggering actions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
television/television.rs |
Adds rendering relevance + action handlers for half-page selection movement. |
television/screen/help_panel.rs |
Includes half-page actions in the “relevant actions” set for help display. |
television/action.rs |
Adds new Action variants and user-facing descriptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@alexpasmantier may I ask you to take a look on this PR? :) |
Contributor
Author
|
@alexpasmantier ping :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📺 PR Description
Checklist