fix clippy warnings

Author: alexylon

src/api/anthropic.rs

@@ -163,7 +163,7 @@ impl AnthropicClient {
 
                 let line = line.trim_end();
                 let json_str = match line.strip_prefix("data: ") {
-                    Some(s) if s == "[DONE]" => continue,
+                    Some("[DONE]") => continue,
                     Some(s) => s,
                     None => continue,
                 };

src/error_ext.rs

@@ -73,7 +73,7 @@ mod tests {
     fn test_with_context() {
         let result: std::io::Result<()> = Err(io::Error::new(io::ErrorKind::NotFound, "test"));
         let err = result
-            .with_context(|| format!("Failed to read file: test.txt"))
+            .with_context(|| "Failed to read file: test.txt".to_string())
             .unwrap_err();
 
         assert!(matches!(err, SofosError::Context { .. }));

src/repl/conversation.rs

@@ -208,7 +208,7 @@ Show imperial units only when the user explicitly asks for them."#,
         let message_tokens: usize = self
             .messages
             .iter()
-            .map(|m| Self::estimate_message_tokens(m))
+            .map(Self::estimate_message_tokens)
             .sum();
 
         system_tokens + message_tokens

src/repl/mod.rs

@@ -524,9 +524,8 @@ impl Repl {
 
                     if is_400_error && is_image_error && has_images {
                         println!(
-                            "\n{} {}\n",
-                            "⚠️  Image loading error:".bright_yellow().bold(),
-                            "One or more image URLs in the conversation could not be loaded by the API"
+                            "\n{} One or more image URLs in the conversation could not be loaded by the API\n",
+                            "⚠️  Image loading error:".bright_yellow().bold()
                         );
 
                         self.session_state.conversation.remove_last_message();

src/repl/response_handler.rs

@@ -28,6 +28,7 @@ pub struct ResponseHandler {
 }
 
 impl ResponseHandler {
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         client: LlmClient,
         tool_executor: ToolExecutor,

src/session/history.rs

@@ -331,7 +331,12 @@ mod tests {
             SystemPrompt::new_cached_with_ttl("Test system prompt".to_string(), None);
 
         manager
-            .save_session(&session_id, &messages, &[], &[system_prompt.clone()])
+            .save_session(
+                &session_id,
+                &messages,
+                &[],
+                std::slice::from_ref(&system_prompt),
+            )
             .unwrap();
 
         let loaded = manager.load_session(&session_id).unwrap();
@@ -353,7 +358,7 @@ mod tests {
                 &session_id1,
                 &[Message::user("First session")],
                 &[],
-                &[system_prompt.clone()],
+                std::slice::from_ref(&system_prompt),
             )
             .unwrap();
 

src/tools/image.rs

@@ -45,12 +45,11 @@ pub fn detect_image_reference(text: &str) -> Option<ImageReference> {
     let trimmed = text.trim();
 
     // Strip common trailing punctuation that might be attached to paths in sentences
-    let cleaned = trimmed.trim_end_matches(|c| matches!(c, '.' | ',' | ';' | ':' | '!' | '?'));
+    let cleaned = trimmed.trim_end_matches(['.', ',', ';', ':', '!', '?']);
 
-    if cleaned.starts_with("http://") || cleaned.starts_with("https://") {
-        if is_image_url(cleaned) {
-            return Some(ImageReference::WebUrl(cleaned.to_string()));
-        }
+    if (cleaned.starts_with("http://") || cleaned.starts_with("https://")) && is_image_url(cleaned)
+    {
+        return Some(ImageReference::WebUrl(cleaned.to_string()));
     }
 
     if has_image_extension(cleaned) {
@@ -239,12 +238,12 @@ impl ImageLoader {
 pub fn extract_image_references(input: &str) -> (String, Vec<ImageReference>) {
     let mut remaining_text = String::new();
     let mut references = Vec::new();
-    let mut chars = input.chars().peekable();
+    let chars = input.chars();
     let mut current_word = String::new();
     let mut in_quotes = false;
     let mut quote_char = ' ';
 
-    while let Some(ch) = chars.next() {
+    for ch in chars {
         match ch {
             // Only treat quotes as delimiters if we're at a word boundary (current_word is empty)
             // This prevents apostrophes in contractions like "don't" from being treated as quotes

src/tools/permissions.rs

@@ -481,10 +481,8 @@ impl PermissionManager {
         if result == CommandPermission::Denied || result == CommandPermission::Ask {
             return result;
         }
-        if result == CommandPermission::Allowed {
-            if self.is_read_explicit_allow(original) {
-                return CommandPermission::Allowed;
-            }
+        if result == CommandPermission::Allowed && self.is_read_explicit_allow(original) {
+            return CommandPermission::Allowed;
         }
 
         let canonical_result = self.check_read_permission(canonical);