Avoid some invalidations related to Base.hash#123
Merged
ederc merged 1 commit intoalgebraic-solving:mainfrom Feb 20, 2026
Merged
Avoid some invalidations related to Base.hash#123ederc merged 1 commit intoalgebraic-solving:mainfrom
Base.hash#123ederc merged 1 commit intoalgebraic-solving:mainfrom
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the julia docs, new types should implement the 2-argument version of
hash, as this allows for composeability of hashing and there exists a generic delegation from the 1-arg to the 2-arg version in julia base. Not adhering to this leads to a bunch of invalidations, i.e. basically all methods that usesBase.hashin their body need to be re-compiled once this method from AlgebraicSolving is loaded (cf. oscar-system/Oscar.jl#2525).Furthermore, the julia docs state that
Base.hashshould always return aUInt(i.e. a 64-bit unsigned int on most systems). I added compliance with that by splitting the function into one namedBase.hashthat returns aUInt, and one namedhash_monomialthat returns aMonHash(aka UInt32).cc @fingolfin