Skip to content

Renames + bug correction#133

Open
rprebet wants to merge 5 commits intoalgebraic-solving:mainfrom
rprebet:fix-curve-param
Open

Renames + bug correction#133
rprebet wants to merge 5 commits intoalgebraic-solving:mainfrom
rprebet:fix-curve-param

Conversation

@rprebet
Copy link
Copy Markdown
Contributor

@rprebet rprebet commented Mar 25, 2026

  • Rename files/functions/types for curve parametrization to avoid confusion with parametric/rational curves. It consists mainly in swapping "rational" and "curve".
  • Bug correction in the computation of zero-dim parametrization of fibers of the curves. This was not replacing non-generic fibers by new ones, as designed first.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 25, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.91%. Comparing base (8f34ae6) to head (9673dc4).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/algorithms/curve-param.jl 90.90% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   83.59%   83.91%   +0.31%     
==========================================
  Files          26       32       +6     
  Lines        2768     3171     +403     
==========================================
+ Hits         2314     2661     +347     
- Misses        454      510      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wegank
Copy link
Copy Markdown
Contributor

wegank commented Mar 27, 2026

Would it be advisable to keep rational_curve_parametrization as a temporary alias, with a deprecation warning saying that the function has been renamed to curve_rational_parametrization, to avoid immediately breaking existing external code?

@mohabsafey
Copy link
Copy Markdown
Collaborator

Very sorry to be slow on this. Since rational_curve_parametrization was quite recent and is not used yet in Oscar, I think we should go for the name change directly (precisely to avoid that this name is used). Otherwise, I am fine with this PR. @ederc , what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants