Open
Conversation
Collaborator
|
Many thanks for all of this. As far as I understand, the roadmap function fails when a change of variables is needed which might be restrictive. Do you confirm? |
Contributor
Author
|
Do you suggest performing a random change of variables as soon/long as the roadmap function fails? |
Collaborator
|
Sorry for the late reply. All apologies. Yes, I think that the change of variables should be done automatically. Also, note that this is needed only to ensure dimension properties. Hence, we could have these changes of variables chosen deterministically so that the function returns always the same roadmap for a given input (the output should not depend on the execution). This is how I do in raglib (you can have a look or I can show you). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings functions to compute a roadmap for a smooth and bounded real algebraic set, together with query points.
This comes with a new optimized data structure for roadmaps and associated functions.
Substantial additional documentation is also included.