Implementation of monomial divisibility diagrams for efficient membership tests#129
Open
ThTer11 wants to merge 22 commits intoalgebraic-solving:mainfrom
Open
Implementation of monomial divisibility diagrams for efficient membership tests#129ThTer11 wants to merge 22 commits intoalgebraic-solving:mainfrom
ThTer11 wants to merge 22 commits intoalgebraic-solving:mainfrom
Conversation
ThTer11
changed the title
…d add automatic tests
RafaelDavidMohr
force-pushed
the
withmdd
branch
from
f9be7f7 to
73e4f1b
Compare
Collaborator
|
@ThTer11 I did some small changes, for me the main code looks good now. So if you think it's good as well, you can remove the Draft status. The one bigger thing I did was to integrate the Hilbert series computation via MDD's into the already present functionality for computing Hilbert series. In the user function |
Collaborator
|
Many thanks for this. It looks like the tests are not successful. Can you have a look? |
Collaborator
Fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft pull request implements monomial divisibility diagrams (MDDs) in AlgebraicSolving.jl, following the ideas from our paper A data structure for monomial ideals with applications to signature Gröbner bases (Pierre Lairez, Rafael Mohr, Théo Ternier, link: https://arxiv.org/abs/2601.05026).
The goal is to speed up membership tests in monomial ideals, which are used in the signature Gröbner basis implementation.