Skip to content

Fix issue when calling _core_groebner_basis_array from Oscar #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ederc merged 1 commit into from
Mar 27, 2026
+4 −4
Merged

Fix issue when calling _core_groebner_basis_array from Oscar #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/algorithms/groebner-bases.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,16 +210,16 @@ function _core_groebner_basis_array(

# convert to julia array, also give memory management to julia
jl_ld = gb_ld[]
jl_len = Int32.(Base.unsafe_wrap(Array, gb_len[], jl_ld))
jl_exp = Int32.(Base.unsafe_wrap(Array, gb_exp[], nr_terms * nr_vars))
jl_len = Vector{Int32}(Base.unsafe_wrap(Array, gb_len[], jl_ld))
jl_exp = Vector{Int32}(Base.unsafe_wrap(Array, gb_exp[], nr_terms * nr_vars))

# coefficient handling depending on field characteristic
if field_char == 0
ptr = reinterpret(Ptr{BigInt}, gb_cf[])
jl_cf = BigInt.([deepcopy(unsafe_load(ptr, i)) for i in 1:nr_terms])
jl_cf = BigInt[deepcopy(unsafe_load(ptr, i)) for i in 1:nr_terms]
else
ptr = reinterpret(Ptr{Int32}, gb_cf[])
jl_cf = Int32.(Base.unsafe_wrap(Array, ptr, nr_terms))
jl_cf = Vector{Int32}(Base.unsafe_wrap(Array, ptr, nr_terms))
end

ccall((:free_f4_julia_result_data, libneogb), Nothing,
Expand Down
Loading