Skip to content

Add parametric ideal and interpolation-based algorithms#146

Open
wegank wants to merge 1 commit into
algebraic-solving:mainfrom
wegank:param-ideal-init
Open

Add parametric ideal and interpolation-based algorithms#146
wegank wants to merge 1 commit into
algebraic-solving:mainfrom
wegank:param-ideal-init

Conversation

@wegank

@wegank wegank commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This PR introduces ParametricIdeal{K}, a new type for polynomial ideals defined over $\mathbb{K}=\mathbb{Q}(y_1,\dots,y_t)$ instead of $\mathbb{Q}$.

To support computations in this setting, the PR implements interpolation-based algorithms for the computation of Gröbner bases, multiplication/Hermite matrices, and parametrizations.

@wegank wegank force-pushed the param-ideal-init branch from 14a76b0 to 1f83fda Compare June 18, 2026 11:14
@codecov-commenter

codecov-commenter commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 62.36264% with 137 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.14%. Comparing base (91d7230) to head (e109eac).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/algorithms/param-ideal/hermite-matrices.jl 32.95% 59 Missing ⚠️
src/algorithms/param-ideal/groebner-bases.jl 70.00% 42 Missing ⚠️
.../algorithms/param-ideal/multiplication-matrices.jl 50.00% 27 Missing ⚠️
src/algorithms/param-ideal/parametrizations.jl 85.41% 7 Missing ⚠️
src/types.jl 94.11% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   83.62%   82.14%   -1.49%     
==========================================
  Files          32       37       +5     
  Lines        3188     3657     +469     
==========================================
+ Hits         2666     3004     +338     
- Misses        522      653     +131     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wegank wegank force-pushed the param-ideal-init branch 2 times, most recently from e109eac to 735af8b Compare June 18, 2026 12:25
@wegank wegank force-pushed the param-ideal-init branch from 735af8b to 7e7355d Compare June 18, 2026 12:57
@wegank wegank marked this pull request as ready for review June 19, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants