Merge pull request #245 from ederc/export-elim-fixes

mohabsafey · web-flow · commit 0007be3bbcb1 · 2025-11-28T13:24:16.000+01:00
Fixes export of GB over QQ for elimination orderings
diff --git a/src/msolve/lifting-gb.c b/src/msolve/lifting-gb.c
@@ -1686,7 +1686,7 @@ uint64_t export_results_from_groebner_qq(
         evi[i-1]    =   i;
       }
     } else {
-      for (len_t i = 1; i <= ebl; ++i) {
+      for (len_t i = 1; i < ebl; ++i) {
         evi[i-1]    =   i;
       }
       for (len_t i = ebl+1; i < evl; ++i) {
@@ -1700,7 +1700,7 @@ uint64_t export_results_from_groebner_qq(
         len_t idx = gb->lmps[p];
         hm  = gb->hm[idx]+OFFSET;
         int32_t l = gb->modpolys[p]->len;
-        for(int32_t n = 0; n < nve; n++){
+        for(int32_t n = 0; n < nv; n++){
             exp[term * nve + n + elim_block_len] = gb->ldm[p * nv + n];
         }
         mpz_set(cf_qq[term], gb->modpolys[p]->lm);

Original file line number	Diff line number	Diff line change
`@@ -1686,7 +1686,7 @@ uint64_t export_results_from_groebner_qq(`
`1686`	`1686`	`evi[i-1] = i;`
`1687`	`1687`	`}`
`1688`	`1688`	`} else {`
`1689`		`- for (len_t i = 1; i <= ebl; ++i) {`
	`1689`	`+ for (len_t i = 1; i < ebl; ++i) {`
`1690`	`1690`	`evi[i-1] = i;`
`1691`	`1691`	`}`
`1692`	`1692`	`for (len_t i = ebl+1; i < evl; ++i) {`
`@@ -1700,7 +1700,7 @@ uint64_t export_results_from_groebner_qq(`
`1700`	`1700`	`len_t idx = gb->lmps[p];`
`1701`	`1701`	`hm = gb->hm[idx]+OFFSET;`
`1702`	`1702`	`int32_t l = gb->modpolys[p]->len;`
`1703`		`- for(int32_t n = 0; n < nve; n++){`
	`1703`	`+ for(int32_t n = 0; n < nv; n++){`
`1704`	`1704`	`exp[term * nve + n + elim_block_len] = gb->ldm[p * nv + n];`
`1705`	`1705`	`}`
`1706`	`1706`	`mpz_set(cf_qq[term], gb->modpolys[p]->lm);`