Skip to content

Commit 339f1c4

Browse files
authored
Merge pull request #296 from vneiger/fix_warnings_fglm
Fix compilation warnings [fglm]
2 parents 0208dbd + 7332f41 commit 339f1c4

6 files changed

Lines changed: 64 additions & 400 deletions

File tree

src/fglm/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ noinst_LTLIBRARIES = libfglm.la
22
libfglm_la_SOURCES = fglm_core.c
33
libfglm_ladir = $(includedir)/msolve/fglm
44
libfglm_la_HEADERS = fglm.h
5-
libfglm_la_CFLAGS = $(SIMD_FLAGS) $(CPUEXT_FLAGS) $(OPENMP_CFLAGS)
5+
libfglm_la_CFLAGS = $(SIMD_FLAGS) $(CPUEXT_FLAGS) $(OPENMP_CFLAGS) -Wall -Wextra
66

77
EXTRA_DIST = fglm.h \
88
libfglm.h \

src/fglm/berlekamp_massey.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,7 @@ void nmod_berlekamp_massey_add_point_modif(
191191
B->points->length = old_length + 1;
192192
}
193193

194-
//shift ne sert pas
195-
int nmod_em_gcd(nmod_berlekamp_massey_t B, long shift){
194+
int nmod_em_gcd(nmod_berlekamp_massey_t B){
196195
slong i, l, k, queue_len, queue_lo, queue_hi;
197196
queue_lo = B->npoints; // vaut 0 en entree
198197
queue_hi = B->points->length; //vaut 2*dim ou dim est la dimension du quotient
@@ -316,7 +315,6 @@ int nmod_em_gcd(nmod_berlekamp_massey_t B, long shift){
316315
}
317316

318317

319-
//shift ne sert pas
320318
int nmod_em_gcd_preinstantiated(nmod_berlekamp_massey_t B, long shift){
321319
slong l, k, queue_len, queue_lo, queue_hi;
322320
queue_lo = B->npoints; // vaut 0 en entree
@@ -436,7 +434,6 @@ int nmod_em_gcd_preinstantiated(nmod_berlekamp_massey_t B, long shift){
436434
FLINT_ASSERT(2*nmod_poly_degree(B->V1) <= B->npoints);
437435
FLINT_ASSERT(2*nmod_poly_degree(B->R0) >= B->npoints);
438436
FLINT_ASSERT(2*nmod_poly_degree(B->R1) < B->npoints);
439-
440437

441438
return 1;
442439
}

src/fglm/data_fglm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ static inline param_t *allocate_fglm_param(mp_limb_t prime, long nvars){
166166
static inline void free_fglm_param(param_t *param){
167167
nmod_poly_clear(param->elim);
168168
nmod_poly_clear(param->denom);
169-
for(szmat_t i = 0; i < param->nvars-1; i++){
169+
for(szmat_t i = 0; i < (unsigned int)param->nvars-1; i++){
170170
nmod_poly_clear(param->coords[i]);
171171
}
172172
free(param->coords);

0 commit comments

Comments
 (0)