Merge pull request #254 from wegank/non-shape-pos-fix

mohabsafey · web-flow · commit bfd23400fb1d · 2025-12-15T17:40:19.000+01:00
Fix heap overflow on computing parametrizations in non-shape-position case
diff --git a/src/fglm/fglm_core.c b/src/fglm/fglm_core.c
@@ -1280,7 +1280,7 @@ int compute_parametrizations_non_shape_position_case(param_t *param,
         }
         else{
           nmod_poly_fit_length(param->coords[nvars-2-nc],
-                               param->elim->length-1 );
+                               FLINT_MAX(2, param->elim->length-1) );
           param->coords[nvars-2-nc]->length = data_bms->BMS->R1->length ;
           param->coords[nvars-2-nc]->coeffs[0] = 0;
           param->coords[nvars-2-nc]->coeffs[1] = 0;

Original file line number	Diff line number	Diff line change
`@@ -1280,7 +1280,7 @@ int compute_parametrizations_non_shape_position_case(param_t *param,`
`1280`	`1280`	`}`
`1281`	`1281`	`else{`
`1282`	`1282`	`nmod_poly_fit_length(param->coords[nvars-2-nc],`
`1283`		`- param->elim->length-1 );`
	`1283`	`+ FLINT_MAX(2, param->elim->length-1) );`
`1284`	`1284`	`param->coords[nvars-2-nc]->length = data_bms->BMS->R1->length ;`
`1285`	`1285`	`param->coords[nvars-2-nc]->coeffs[0] = 0;`
`1286`	`1286`	`param->coords[nvars-2-nc]->coeffs[1] = 0;`