Fix evaluation when the input involves only constants#9
Draft
wegank wants to merge 6 commits intoalgebraic-solving:mainfrom
Draft
Fix evaluation when the input involves only constants#9wegank wants to merge 6 commits intoalgebraic-solving:mainfrom
wegank wants to merge 6 commits intoalgebraic-solving:mainfrom
Conversation
wegank
force-pushed
the
raglib-constant-fix
branch
from
043a8da to
735b759
Compare
wegank
force-pushed
the
raglib-constant-fix
branch
from
346655f to
85306a7
Compare
wegank
commented
Apr 24, 2026
wegank
commented
Apr 24, 2026
| return []; | ||
| end if; | ||
|
|
||
| NewEquations := select(_pol -> not type(_pol, constant), Equations): |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| NewEquations := select(_pol -> not type(_pol, constant), Equations): | |
| NewEquations := select(_pol -> not type(_pol, constant), Equations); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ConstantSolveFamilyto handle the case where all polynomials are constant. It returns[[]]when the constant polynomials have the desired signs, and[]otherwise.While this fixes
RAG:-PointsPerComponents([], pos, ineq), it doesn't resolve the issue where the equations are a list of zeros. To address the issue, this PR adds preliminary checks on the inputs ofSemiAlgebraicSolveand only passes filteredEquationstoSemiAlgebraicSolveIterateOnFamilies.