fix(insights): skip pushing events if empty#170
Merged
Conversation
if the events are invalid or empty, we don't send the events. Testing this required a slight change to the event service, as the InsightsClient is final, and can thus not be extended to make a mock. There's now a private "withClient" method that allows a subset of InsightsClient. [CR-9915]
This comment was marked as resolved.
This comment was marked as resolved.
dhayab
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CR-9915
Describe your change
ensure we don't send an empty payload.
Testing this required a slight change to the event service, as the InsightsClient is final, and can thus not be extended to make a mock. There's now a private "withClient" method that allows a subset of InsightsClient.
What problem is this fixing?
if the events are invalid or empty, we don't send the events, as the insights API returns 422 if you send an empty payload.