Skip to content

fix(preset-algolia): keep separator highlight when reverse-highlight siblings disagree #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haroenv merged 1 commit into from
Jun 19, 2026
+19 −2
Merged

fix(preset-algolia): keep separator highlight when reverse-highlight siblings disagree #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/autocomplete-preset-algolia/src/highlight/__tests__/isPartHighlighted.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,23 @@ describe('isPartHighlighted', () => {
).toEqual(true);
});

test('does not inherit sibling state when siblings disagree', () => {
// The separator (index 1) sits between a highlighted ("Amazon") and a
// non-highlighted ("Fire") part. Since the siblings disagree, the separator
// must keep its own `isHighlighted` value rather than being treated as
// highlighted-from-siblings.
expect(
isPartHighlighted(
[
{ isHighlighted: true, value: 'Amazon' },
{ isHighlighted: false, value: ' - ' },
{ isHighlighted: false, value: 'Fire' },
],
1
)
).toEqual(false);
});

test('returns the isHighlighted value with both siblings', () => {
expect(
isPartHighlighted(
Expand Down
4 changes: 2 additions & 2 deletions packages/autocomplete-preset-algolia/src/highlight/isPartHighlighted.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ function unescape(value: string): string {

export function isPartHighlighted(parts: ParsedAttribute[], i: number) {
const current = parts[i];
const isNextHighlighted = parts[i + 1]?.isHighlighted || true;
const isPreviousHighlighted = parts[i - 1]?.isHighlighted || true;
const isNextHighlighted = parts[i + 1]?.isHighlighted ?? true;
const isPreviousHighlighted = parts[i - 1]?.isHighlighted ?? true;

if (
!hasLetterOrNumber.test(unescape(current.value)) &&
Expand Down