refactor(core): add non-breaking core package#7018
Draft
shaejaz wants to merge 17 commits into
Draft
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 1372 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes.
More templates
algoliasearch-helper
instantsearch-ui-components
instantsearch.css
instantsearch.js
react-instantsearch
react-instantsearch-core
react-instantsearch-nextjs
react-instantsearch-router-nextjs
vue-instantsearch
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Non-breaking consolidation of shared code into
instantsearch-coreso React, Vue, and the JS flavor depend on a single source of truth instead of reaching intoinstantsearch.js.Changes
lib/chat/(Chat class, types, tool helpers,openChat/isChatBusy) now lives ininstantsearch-core; connector and tests moved alongside it. JS / React / Vue widgets import frominstantsearch-core.InstantSearchclass moved to core.instantsearch.jsre-exports it for backward compatibility;react-instantsearch-coreconsumes it directly from core via a namedInstantSearchexport.instantsearchfactory export from core. Vue swapsimport instantsearch from 'instantsearch.js/es'→import { instantsearch } from 'instantsearch-core'across 5 files (component, SSR mixin, 3 tests).instantsearch-ui-componentsre-exports removed. Consumers import UI primitives frominstantsearch-ui-componentsdirectly instead of throughinstantsearch.js.instantsearch.jsas a runtime dependency fromreact-instantsearch,react-instantsearch-core, andreact-instantsearch-router-nextjs. Vue keeps it as an optional peer (only forEXPERIMENTAL_connectConfigureRelatedItems).RefinementListWidgetParamsfields React actually uses (searchable,searchablePlaceholder,searchableSelectOnSubmit) rather than re-exporting a JS-widget-shaped type.