Skip to content

chore(lint): fix typescript-eslint(no-deprecated) (118 violations, 10 files) #7034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(lint): fix typescript-eslint(no-deprecated) (118 violations, 10 files) #7034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/instantsearch.js/src/components/Template/__tests__/Template-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
*/
/** @jsx h */

/* oxlint-disable typescript-eslint/no-deprecated -- enzyme's mount/shallow are typed as deprecated but remain the supported test API in this codebase */
Copy link
Copy Markdown
Contributor

@Haroenv Haroenv May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't a real solution, why did it not change to testing library instead of enzyme as the deprecation implies?


import { mount, shallow } from '@instantsearch/testutils/enzyme';
import { render } from '@testing-library/preact';
import { h } from 'preact';
Expand Down
2 changes: 2 additions & 0 deletions ....js/src/connectors/configure-related-items/__tests__/connectConfigureRelatedItems-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
* @jest-environment @instantsearch/testutils/jest-environment-jsdom.ts
*/

/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally exercise the deprecated connectConfigureRelatedItems connector this file covers */

import { createSearchClient } from '@instantsearch/mocks';
import { wait } from '@instantsearch/testutils/wait';

Expand Down
1 change: 1 addition & 0 deletions packages/instantsearch.js/src/helpers/__tests__/highlight-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally exercise the deprecated helper this file covers */
import highlight from '../highlight';

const NONE = 'none' as const;
Expand Down
1 change: 1 addition & 0 deletions packages/instantsearch.js/src/helpers/__tests__/insights-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* @jest-environment @instantsearch/testutils/jest-environment-jsdom.ts
*/

/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally exercise the deprecated insights/readDataAttributes/writeDataAttributes helpers this file covers */
import { warning, serializePayload } from '../../lib/utils';
import insights, { writeDataAttributes, readDataAttributes } from '../insights';

Expand Down
1 change: 1 addition & 0 deletions packages/instantsearch.js/src/helpers/__tests__/reverseHighlight-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally exercise the deprecated helper this file covers */
Copy link
Copy Markdown
Contributor

@Haroenv Haroenv May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally exercise the deprecated helper this file covers */
/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally use the deprecated helper this file covers */

import reverseHighlight from '../reverseHighlight';

const NONE = 'none' as const;
Expand Down
1 change: 1 addition & 0 deletions packages/instantsearch.js/src/helpers/__tests__/reverseSnippet-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally exercise the deprecated helper this file covers */
import reverseSnippet from '../reverseSnippet';

const NONE = 'none' as const;
Expand Down
1 change: 1 addition & 0 deletions packages/instantsearch.js/src/helpers/__tests__/snippet-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* oxlint-disable typescript-eslint/no-deprecated -- tests intentionally exercise the deprecated helper this file covers */
import snippet from '../snippet';

const NONE = 'none' as const;
Expand Down
1 change: 1 addition & 0 deletions packages/instantsearch.js/src/index.es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* oxlint-disable typescript-eslint/no-deprecated -- this entry point intentionally re-exports deprecated helpers for backwards compatibility */
import {
snippet,
reverseSnippet,
Expand Down
1 change: 1 addition & 0 deletions packages/instantsearch.js/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* oxlint-disable typescript-eslint/no-deprecated -- this entry point intentionally re-exports deprecated helpers for backwards compatibility */
import * as connectors from './connectors/index';
import * as helpers from './helpers/index';
import { createInfiniteHitsSessionStorageCache } from './lib/infiniteHitsCache/index';
Expand Down
2 changes: 2 additions & 0 deletions packages/instantsearch.js/src/widgets/geo-search/__tests__/geo-search-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
* @jest-environment @instantsearch/testutils/jest-environment-jsdom.ts
*/

/* oxlint-disable typescript-eslint/no-deprecated -- preact's render is deprecated in v11 and google.maps.Marker is deprecated; the widget still uses them so the tests must too */

/* global google */
import {
createSearchClient,
Expand Down