fixed

Author: codelion

.github/workflows/test.yml

@@ -201,11 +201,12 @@ jobs:
         OPTILLM_API_KEY=optillm python -m pytest tests/test_conversation_logging_approaches.py -v --tb=short
 
         echo "Running conversation logging server tests..."
-        OPTILLM_API_KEY=optillm python -m pytest tests/test_conversation_logging_server.py -v --tb=short
+        OPTILLM_API_KEY=optillm OPTILLM_CONVERSATION_LOG_DIR=/tmp/optillm_conversations python -m pytest tests/test_conversation_logging_server.py -v --tb=short
 
         echo "All conversation logging tests completed successfully!"
       env:
         OPTILLM_API_KEY: optillm
+        OPTILLM_CONVERSATION_LOG_DIR: /tmp/optillm_conversations
         HF_TOKEN: ${{ secrets.HF_TOKEN }}
 
     - name: Stop optillm server

tests/test_conversation_logging_server.py

@@ -112,15 +112,20 @@ def setUp(self):
         """Set up test client"""
         if not self.server_available:
             self.skipTest("OptILLM server not available")
-        
+
         self.client = OpenAI(api_key="optillm", base_url="http://localhost:8000/v1")
-        
-        # Determine log directory - use temp dir if we started server, otherwise default
+
+        # Determine log directory - priority order:
+        # 1. temp_log_dir (if we started the server ourselves)
+        # 2. OPTILLM_CONVERSATION_LOG_DIR environment variable (for CI)
+        # 3. Default ~/.optillm/conversations
         if self.temp_log_dir:
             self.log_dir = self.temp_log_dir
+        elif os.getenv("OPTILLM_CONVERSATION_LOG_DIR"):
+            self.log_dir = Path(os.getenv("OPTILLM_CONVERSATION_LOG_DIR"))
         else:
             self.log_dir = Path.home() / ".optillm" / "conversations"
-        
+
         # Record initial state for comparison
         self.initial_log_files = set(self.log_dir.glob("*.jsonl")) if self.log_dir.exists() else set()