fix: preserve dataType and options across JWT refresh retry (#38)#152
Merged
Merged
Conversation
apiRequest and apiRequestWithoutCompnay reconstruct the call after a token refresh using only (type, endPoint, data), dropping dataType and options. Any retry of a multipart upload then runs through the JSON axios instance instead of the form-data instance, and any caller-supplied abort signal or per-request option is lost. Forwarded dataType and options into both retry calls so the replay matches the original. Closes #38 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apiRequest and apiRequestWithoutCompnay reconstruct the call after a token refresh using only (type, endPoint, data), dropping dataType and options. Any retry of a multipart upload then runs through the JSON axios instance instead of the form-data instance, and any caller-supplied abort signal or per-request option is lost. Forwarded dataType and options into both retry calls so the replay matches the original.
Closes #38
Pull Request Template Chooser
Please click the link that matches your contribution type to load the correct format.
Bug Fix
Use this for fixing broken logic or UI glitches.
New Feature
Use this for adding new functionality or components.
Refactor
Use this for code cleanup, performance tweaks, or technical debt.
General Summary
If you don't want to use a specific template, please provide a brief summary of your changes below.