feat(auth): add GitLab OAuth login and harden Google/GitHub sign-in#235
Merged
Conversation
Adds GitLab as a third social-login provider alongside Google and GitHub: a token-exchange module, server-side identity verification against GitLab /user, a gitlab-signup endpoint, the gitlabId field on the auth record, and a GitLab button on the login and invitation pages. Also reconciles the existing Google/GitHub flows so verification actually runs: the client now forwards the Google id-token and the GitHub/GitLab access token, the backend accepts a single configured client id, and the GitHub/GitLab redirect handlers each ignore the other provider's code so they no longer collide. Manual test cases (with provider app-configuration steps and URLs) for all three providers are added under .claude/test-cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds GitLab as a third social-login provider, and fixes the existing Google/GitHub login so server-side verification actually runs.
GitLab (new)
Modules/gitlabOAuth/— authorization-code → token exchange (sends theredirect_uriGitLab requires).verifyGitlabAuthinauthHelpers.js— re-verifies the identity against GitLab/userbefore issuing a session;gitlab-signupendpoint for invitation signups;gitlabIdadded to theuserAuthschema.GitlabAuth.vue+ tanuki icon, wired into the provider list (gated byVUE_APP_IS_GITLAB_LOGIN).GITLAB_BASE_OAUTH_URL/GITLAB_BASE_API_URL.Google / GitHub (fix)
GOOGLE_CLIENT_ID) rather than the orphanedGOOGLE_OAUTH_CLIENT_ID.?code=; each redirect handler now ignores the other provider''s code so they no longer collide.Docs / tests
.env.exampledocuments every OAuth var for all three providers..claude/test-cases/OAuthGoogleLogin.md,OAuthGithubLogin.md,OAuthGitlabLogin.md— manual test cases with the provider app-configuration steps, console URLs, and env-var tables.Verification
STORAGE_TYPEset;index.jssyntax OK; jest suite passes.No secrets are committed —
.env/frontend/.envare gitignored; only the empty-placeholder.env.exampleis included.🤖 Generated with Claude Code