fix(gantt): render on direct reload + Sprint 2-5 QA test cases#257
Merged
Conversation
When Gantt was the active view on a fresh reload, the Vuex task store was empty (only List/Table/Board mount triggers the load via taskListHelper), so the chart rendered nothing. GanttView now triggers the same loader on mount when the store is empty for the project+sprint, and retries if sprints arrive late; the existing reactive watch renders once data lands. Retains the earlier reopen-crash fix (dhtmlx singleton, no destructor, guarded init). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Per-feature files in .claude/test-cases/ following the existing template: Integrations (Slack+Discord), CSV importer, Trello importer, story points, @mentions, velocity, CFD, reports PDF export, Gantt, recurring tasks. Includes third-party setup steps (Slack app webhook, Discord webhook, Trello JSON export) and Gantt reload/reopen regression cases. Skips BurndownChart (already present); excludes n8n (not built). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related changes from the Sprint 5 QA pass.
Fix — Gantt renders on direct reload (commit 6e9cc3a)
Bug: reloading the page with the Gantt tab active showed an empty chart (0 scheduled + empty Unscheduled tray); reaching Gantt via List worked.
Cause: the project task list is loaded into the Vuex store by whichever task view (List/Table/Board) mounts, via
taskListHelper().groupBy(...). Gantt only read the store, so a direct reload into the Gantt tab left it empty.Fix:
GanttViewtriggers the same loader on mount only when the store is empty for the project+sprint (no double-fetch when arriving from another view), and retries ifsprintsarrive late; the existing reactive watch renders once the data lands. Retains the earlier reopen-crash fix (dhtmlx singleton, nodestructor(), guardedinit()).Docs — Sprint 2–5 feature test cases (commit cd6b4cc)
10 per-feature files in
.claude/test-cases/, matching the folder's existing template (ID | Title | Precondition | Steps | Expected | Actual | Status):Integrations (Slack + Discord), CSV importer, Trello importer, story points, @mentions, velocity, CFD, reports PDF export, Gantt, recurring tasks.
BurndownChart.md(S4-01, already present); excludes n8n (not implemented).🤖 Generated with Claude Code