docs(branching): merge-commit promotions so release-please auto-cuts releases#264
Merged
Merged
Conversation
Squash-merging the staging->main promotion collapses every feat/fix into one chore commit, so release-please sees nothing releasable and never cuts the release (hit through v14.4.0, cut manually each time). Merging the promotion with a merge commit puts the conventional commits on main, so release-please opens its Release PR and tags automatically -- and keeps main an ancestor of staging, removing the back-merge conflicts too. Documents the merge-method rule, the new release steps, and a manual fallback. Pairs with a branch-protection change (allow merge commits / drop required linear history on main). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permanent fix for "release tag not cut after promotion"
Root cause: the
staging β mainpromotion was squash-merged, collapsing everyfeat/fixinto a singlechore(release)commit. release-please reads Conventional Commits onmain, saw only achore, and cut nothing β so every release (through v14.4.0) needed a manual tag + changelog.Fix (Option 1 β chosen): merge the promotion with a merge commit instead of squashing. Then:
mainstays an ancestor ofstaging, so back-merges stop conflicting on release files β a second recurring pain gone.This PR updates BRANCHING.md:
staging, merge commit, release-please cuts the tag).On GitHub β Settings β Branches β
main(or the equivalent Ruleset): turn OFF "Require linear history" and ensure "Allow merge commits" is enabled. Without that, GitHub won't offer the merge-commit option for the promotion. Docs-only change here; the setting is what activates it.π€ Generated with Claude Code