-
Notifications
You must be signed in to change notification settings - Fork 77
[feat] HSTUMatch: request-time-anchored time bias (fix ts_gap semantics) #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
13ed18e
[feat] gr position op: optional explicit query_time anchor for time bias
tiankongdeguiji 5a59ad1
[feat] HSTUMatchEncoder: thread per-row query_time through positional…
tiankongdeguiji 58c11ed
[feat] HSTUMatch: query_time group -> request-time-anchored time bias
tiankongdeguiji 3515190
[test] HSTUMatch: exercise query_time end-to-end on kuairand fixtures
tiankongdeguiji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
query_timegroup is detected purely by name, with no check that it resolves to a single scalar feature (dim 1). If it's misconfigured with multiple features (or a sparse/embedded feature), the grouped tensor is[B, K]and the op doesquery_time.view(-1)→ lengthB*K: the triton kernel then readsQueryTime + off_bpast the buffer (silent OOB, see other comment) and the pytorch path either errors deep inside the op or, atK/length 1, silently broadcasts one row to all users.Consider a construction-time guard mirroring the adjacent
contextualcheck (lines 90-97), e.g. assertembedding_group.group_total_dim("query_time") == 1with a message naming the group.Separately: when this group is configured but
positional_encoder.use_time_encoding=false(or nopositional_encoder), the anchor is fetched in_preprocessand silently dropped (positional_encoder.py:115). Since driving the time bias is the group's only purpose, a warning or a hard check thatquery_timeimpliesuse_time_encodingwould save a hard-to-debug silent no-op.