Skip to content

support uthread on windows with msvc#467

Open
c8ef wants to merge 2 commits intoalibaba:mainfrom
c8ef:uthread-win
Open

support uthread on windows with msvc#467
c8ef wants to merge 2 commits intoalibaba:mainfrom
c8ef:uthread-win

Conversation

@c8ef
Copy link
Copy Markdown
Collaborator

@c8ef c8ef commented Apr 4, 2026

Why

related: #451

What is changing

Example

@c8ef c8ef marked this pull request as ready for review April 4, 2026 15:05
@c8ef c8ef requested review from ChuanqiXu9 and poor-circle April 4, 2026 15:06
auto f = [&taskEx, &taskNotify]() mutable {
Latch latch(1u);
taskNotify.schedule([latchPtr = &latch]() mutable {
std::this_thread::sleep_for(1us);
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::this_thread::sleep_for with durations less than one millisecond on Windows gets rounded up to the system timer tick, which is typically around 1ms to 15.6ms, causing tests to run slower on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant