fix(extension): detect stalled background worker#498
Open
huyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXT_HEALTH_CHECKmessage handled by the extension background service workerTabsControllerverify the background worker before task startupsendMessagecalls with a short timeout and raise an actionable recovery error instead of returningnullWhy
Issue #452 reports the side panel becoming unresponsive when Chrome MV3 leaves the extension service worker in a stuck/inactive state. The current tab-control path logs
chrome.runtime.sendMessagefailures and returnsnull, which can turn the real service-worker problem into a less helpful null dereference during task startup.This keeps the service worker stateless/restartable, but gives the side panel a deterministic health probe and a clear failure message that points to the maintainer-provided recovery steps from #452.
This is intentionally scoped to the background/TabsController path and does not touch the sidepanel UI copy, so it complements the existing startup-guidance PR without overlapping its file scope.
Validation
npm ci --ignore-scripts --no-audit --no-fund(npm 10.9.4 reports the repo's npm ^11.6.3 engine warning)npm run postinstall --workspace=@page-agent/extnpm run typechecknpx eslint packages/extension/src/agent/TabsController.ts packages/extension/src/entrypoints/background.tsgit diff --checknpm run build