Skip to content

Commit 4b4e81b

Browse files
committed
Address ChainDataSplit tail parameter order review
1 parent 8332390 commit 4b4e81b

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/paimon/core/table/source/split.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,8 @@ Result<std::unordered_map<std::string, std::string>> ReadStringMap(DataInputStre
210210
}
211211

212212
Result<std::shared_ptr<ChainDataSplitImpl>> ReadChainDataSplitTail(
213-
const std::shared_ptr<DataSplitImpl>& base_split, DataInputStream* in,
214-
const std::shared_ptr<MemoryPool>& pool) {
213+
const std::shared_ptr<DataSplitImpl>& base_split, const std::shared_ptr<MemoryPool>& pool,
214+
DataInputStream* in) {
215215
PAIMON_ASSIGN_OR_RAISE(bool all_snapshot_split, in->ReadValue<bool>());
216216
PAIMON_ASSIGN_OR_RAISE(BinaryRow read_partition,
217217
SerializationUtils::DeserializeBinaryRow(in, pool.get()));
@@ -327,7 +327,7 @@ Result<std::shared_ptr<Split>> Split::Deserialize(const char* buffer, size_t len
327327
if (pos == stream_length) {
328328
return data_split;
329329
} else if (data_split->BucketPath() == ChainDataSplitImpl::VIRTUAL_BUCKET_PATH) {
330-
auto chain_split = ReadChainDataSplitTail(data_split, &in, pool);
330+
auto chain_split = ReadChainDataSplitTail(data_split, pool, &in);
331331
if (!chain_split.ok()) {
332332
return Status::Invalid(fmt::format("invalid ChainDataSplit byte stream: {}",
333333
chain_split.status().ToString()));
@@ -337,7 +337,7 @@ Result<std::shared_ptr<Split>> Split::Deserialize(const char* buffer, size_t len
337337
PAIMON_ASSIGN_OR_RAISE(bool is_fallback, in.ReadValue<bool>());
338338
return std::make_shared<FallbackDataSplit>(data_split, is_fallback);
339339
} else {
340-
auto chain_split = ReadChainDataSplitTail(data_split, &in, pool);
340+
auto chain_split = ReadChainDataSplitTail(data_split, pool, &in);
341341
if (!chain_split.ok()) {
342342
return Status::Invalid(fmt::format("invalid ChainDataSplit byte stream: {}",
343343
chain_split.status().ToString()));

0 commit comments

Comments
 (0)